=sbt Do retry connection in Player. #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdedetrich
reviewed
Aug 8, 2023
| private def tryConnectToController(): Unit = { | ||
| Try(reconnect()) match { | ||
| case Success(r) => connectionRef.set(r) | ||
| case Failure(ex) => |
There was a problem hiding this comment.
Is it worth it to use exponential backoff here or is that excessive?
There was a problem hiding this comment.
reconnect-backoff = 1s which is used in the reconnect()
[info] [JVM-2-MultiDcLastNodeMultiJvmNode2] [ERROR] [08/08/2023 10:05:01.021] [MultiDcLastNode-pekko.actor.default-dispatcher-6] [PlayerHandler(pekko://MultiDcLastNode)] Error when try to connect to remote addr:[localhost/127.0.0.1:4711] will retry, time left:[-4301592 nanoseconds], cause:[Connection refused: localhost/127.0.0.1:4711].
[info] [JVM-2-MultiDcLastNodeMultiJvmNode2] [ERROR] [08/08/2023 10:05:01.048] [MultiDcLastNode-pekko.actor.default-dispatcher-18] [PlayerHandler(pekko://MultiDcLastNode)] Error when try to connect to remote addr:[localhost/127.0.0.1:4711] will retry, time left:[980216623 nanoseconds], cause:[Connection refused: localhost/127.0.0.1:4711].I tested it on my box, works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #547
and
refs: apache/pekko-http#297