Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!sbt Use multiJvmPlugin from pekko. #297

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Aug 7, 2023

Just copy code from pekko, better to submit this upstream, will do later.

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved as temporary solution - if it doesn't help, we should probably revert this - if it does work, we should be looking at creating a shared sbt plugin with this change

@jrudolph
Copy link
Contributor

jrudolph commented Aug 7, 2023 via email

@He-Pin
Copy link
Member Author

He-Pin commented Aug 7, 2023

What problem does it solve?

It start the Player only after The Controller can be connected.

Otherwise a connection refused may be raised and the test is failed.

@He-Pin He-Pin merged commit 1f5b25d into apache:main Aug 7, 2023
10 checks passed
@He-Pin He-Pin deleted the multijvm-waiting branch August 7, 2023 17:14
@mdedetrich
Copy link
Contributor

approved as temporary solution - if it doesn't help, we should probably revert this - if it does work, we should be looking at creating a shared sbt plugin with this change

@pjfanning This is probably a good candidate to include in the incubator-pekko-sbt-build I was talking about

@He-Pin
Copy link
Member Author

He-Pin commented Aug 8, 2023

That's true, the sbt one seems unmaintained at least for now.

@mdedetrich
Copy link
Contributor

That's true, the sbt one seems unmaintained at least for now.

I assume you are talking about https://github.com/sbt/sbt-multi-jvm? If so do you know for what reasons we aren't using this plugin, i.e. is it missing anything? Rather than having all of this extra code that we have to maintain ourselves its always ideal to use an upstream version and while its true that it hasn't really been maintained, the current sbt maintainers are very responsive when it comes to accepting upstream PR's.

If its shown that you are doing extensive contributions to an sbt community project they can add you as maintainers (I am already a maintainer for sbt-github-actions for example).

@He-Pin
Copy link
Member Author

He-Pin commented Aug 8, 2023

@mdedetrich

  1. We need wait the Controller transited to connectable before start the Player.
  2. Need submit a PR to sbt-multi-jvm and waiting a new snapshot, which may take sometimes and is not a quick fix.
  3. I did not diff the code with sbt-multi-jvm line by line, but there must be some reason for Akka was keep it separately

@mdedetrich
Copy link
Contributor

@He-Pin Lets discuss in apache/pekko#548

@jrudolph
Copy link
Contributor

jrudolph commented Aug 8, 2023 via email

@He-Pin
Copy link
Member Author

He-Pin commented Aug 8, 2023

Let's me submit a fix and then this code will not be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants