PARQUET-2414: Add test file for additional BYTE_STREAM_SPLIT types #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new data file that allows exercising BYTE_STREAM_SPLIT for all supported types: FLOAT, DOUBLE, INT32, INT64, FIXED_LEN_BYTE_ARRAY (the latter with several widths and logical types). For each type, two columns are provided with the same values: one PLAIN-encoded, the other BYTE_STREAM_SPLIT-encoded.
|
This should not be merged until PARQUET-2414 is voted on. |
wgtmac
approved these changes
Feb 20, 2024
| It contains 7 pairs of columns, each in two variants containing the same | ||
| values: one `PLAIN`-encoded and one `BYTE_STREAM_SPLIT`-encoded: | ||
| ``` | ||
| Version: 2.6 |
There was a problem hiding this comment.
hmm... it seems we need to fix the version so here can correctly displays version 2.11
There was a problem hiding this comment.
That will have to be part of the final C++ PR. We do not need the C++ changes to fix this README if we want to, though.
There was a problem hiding this comment.
(also see apache/arrow#40096)
pitrou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new data file that allows exercising BYTE_STREAM_SPLIT for all supported types: FLOAT, DOUBLE, INT32, INT64, FIXED_LEN_BYTE_ARRAY (the latter with several widths and logical types).
For each type, two columns are provided with the same values: one PLAIN-encoded, the other BYTE_STREAM_SPLIT-encoded.