-
Notifications
You must be signed in to change notification settings - Fork 1.5k
PARQUET-2121: Remove descriptions for the removed modules #947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| * Type-specific encoding | ||
| * Hive integration (deprecated) | ||
| * Pig integration | ||
| * Cascading integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the code is still there, do you think we can just add '(deprecated)' here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the comment, @shangxinli! I updated the PR.
Instead of removing the lines, I just added '(deprecated)' to parquet-cascading* and parquet-scrooge in README.md, just like parquet-hive.
|
@sekikn Thanks for working on it! Just leave some minor comments. |
|
Thanks for addressing the comments! There is one left over. After that, I think we can merge it. |
|
@shangxinli I'm afraid I can see just one comment at L69 of README.md... |
|
The only comment left is in the .gitignore file. Question is should we remove 'parquet-scrooge/.cache'? If the code for parquet-scrooge is still there, there may be needed to keep it. |
|
Thank you for the elaboration, @shangxinli! |
Thanks @sekikn for checking! |
Make sure you have checked all steps below.
Jira
Tests
No additional test since it's just a documentation fix.
Commits
Documentation