Skip to content

Commit 4d062dc

Browse files
authored
PARQUET-2121: Remove descriptions for the removed modules (#947)
* PARQUET-2121: Remove descriptions for the removed modules * Add '(deprecated)' to removed modules in README.md instead of removing their line
1 parent c00479d commit 4d062dc

File tree

5 files changed

+6
-176
lines changed

5 files changed

+6
-176
lines changed

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ target
1313
*.orig
1414
*.rej
1515
dependency-reduced-pom.xml
16-
parquet-scrooge/.cache
1716
.idea/*
1817
target/
1918
.cache

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,10 @@ Parquet is a very active project, and new features are being added quickly. Here
6666
* Type-specific encoding
6767
* Hive integration (deprecated)
6868
* Pig integration
69-
* Cascading integration
69+
* Cascading integration (deprecated)
7070
* Crunch integration
7171
* Apache Arrow integration
72-
* Apache Scrooge integration
72+
* Scrooge integration (deprecated)
7373
* Impala integration (non-nested)
7474
* Java Map/Reduce API
7575
* Native Avro support
@@ -92,7 +92,7 @@ Note that to use an Input or Output format, you need to implement a WriteSupport
9292
We've implemented this for 2 popular data formats to provide a clean migration path as well:
9393

9494
### Thrift
95-
Thrift integration is provided by the [parquet-thrift](https://github.com/apache/parquet-mr/tree/master/parquet-thrift) sub-project. If you are using Thrift through Scala, you may be using Twitter's [Scrooge](https://github.com/twitter/scrooge). If that's the case, not to worry -- we took care of the Scrooge/Apache Thrift glue for you in the [parquet-scrooge](https://github.com/apache/parquet-mr/tree/master/parquet-scrooge) sub-project.
95+
Thrift integration is provided by the [parquet-thrift](https://github.com/apache/parquet-mr/tree/master/parquet-thrift) sub-project.
9696

9797
### Avro
9898
Avro conversion is implemented via the [parquet-avro](https://github.com/apache/parquet-mr/tree/master/parquet-avro) sub-project.

parquet-thrift/src/main/java/org/apache/parquet/hadoop/thrift/ThriftReadSupport.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,7 @@ public class ThriftReadSupport<T> extends ReadSupport<T> {
6767
/**
6868
* A {@link ThriftRecordConverter} builds an object by working with {@link TProtocol}. The default
6969
* implementation creates standard Apache Thrift {@link TBase} objects; to support alternatives, such
70-
* as <a href="https://github.com/twitter/scrooge">Twiter's Scrooge</a>, a custom converter can be specified using this key
71-
* (for example, ScroogeRecordConverter from parquet-scrooge).
70+
* as <a href="https://github.com/twitter/scrooge">Twiter's Scrooge</a>, a custom converter can be specified using this key.
7271
*/
7372
private static final String RECORD_CONVERTER_CLASS_KEY = "parquet.thrift.converter.class";
7473

@@ -77,8 +76,7 @@ public class ThriftReadSupport<T> extends ReadSupport<T> {
7776
/**
7877
* A {@link ThriftRecordConverter} builds an object by working with {@link TProtocol}. The default
7978
* implementation creates standard Apache Thrift {@link TBase} objects; to support alternatives, such
80-
* as <a href="https://github.com/twitter/scrooge">Twiter's Scrooge</a>, a custom converter can be specified
81-
* (for example, ScroogeRecordConverter from parquet-scrooge).
79+
* as <a href="https://github.com/twitter/scrooge">Twiter's Scrooge</a>, a custom converter can be specified.
8280
*
8381
* @param conf a mapred jobconf
8482
* @param klass a thrift class
@@ -93,8 +91,7 @@ public static void setRecordConverterClass(JobConf conf,
9391
/**
9492
* A {@link ThriftRecordConverter} builds an object by working with {@link TProtocol}. The default
9593
* implementation creates standard Apache Thrift {@link TBase} objects; to support alternatives, such
96-
* as <a href="https://github.com/twitter/scrooge">Twiter's Scrooge</a>, a custom converter can be specified
97-
* (for example, ScroogeRecordConverter from parquet-scrooge).
94+
* as <a href="https://github.com/twitter/scrooge">Twiter's Scrooge</a>, a custom converter can be specified.
9895
*
9996
* @param conf a configuration
10097
* @param klass a thrift class

parquet_cascading.md

Lines changed: 0 additions & 163 deletions
This file was deleted.

pom.xml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,6 @@
7777
<japicmp.version>0.14.2</japicmp.version>
7878
<shade.prefix>shaded.parquet</shade.prefix>
7979
<hadoop.version>2.10.1</hadoop.version>
80-
<cascading.version>2.7.1</cascading.version>
81-
<cascading3.version>3.1.2</cascading3.version>
8280
<parquet.format.version>2.9.0</parquet.format.version>
8381
<previous.version>1.12.0</previous.version>
8482
<thrift.executable>thrift</thrift.executable>
@@ -461,7 +459,6 @@
461459
<exclude>**/*.parquet</exclude>
462460
<exclude>**/*.avro</exclude>
463461
<exclude>**/*.json</exclude>
464-
<exclude>**/names.txt</exclude> <!-- parquet-cascading test data -->
465462
<exclude>**/*.avsc</exclude>
466463
<exclude>**/*.iml</exclude>
467464
<exclude>**/*.log</exclude>

0 commit comments

Comments
 (0)