Skip to content

PARQUET-1251: Clarify ambiguous min/max stats for FLOAT/DOUBLE #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zivanfi merged 2 commits into from
Mar 26, 2018
Merged

PARQUET-1251: Clarify ambiguous min/max stats for FLOAT/DOUBLE #88

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4327ac5
PARQUET-1251: Describe handling of the ambigous min/max statistics fo…
Mar 20, 2018
6549395
PARQUET-1251: Updates for zi's comments
Mar 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/main/thrift/parquet.thrift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,10 +751,19 @@ union ColumnOrder {
* INT32 - signed comparison
* INT64 - signed comparison
* INT96 (only used for legacy timestamps) - undefined
* FLOAT - signed comparison of the represented value
* DOUBLE - signed comparison of the represented value
* FLOAT - signed comparison of the represented value (*)
* DOUBLE - signed comparison of the represented value (*)
* BYTE_ARRAY - unsigned byte-wise comparison
* FIXED_LEN_BYTE_ARRAY - unsigned byte-wise comparison
*
* (*) Because of the sorting order is not specified properly for floating
* point values (relations vs. total ordering) the following
* compatibility rules should be applied:

@zivanfi zivanfi Mar 26, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add: "when reading statistics".

* - When looking for NaN values, min and max should be ignored.

@zivanfi zivanfi Mar 26, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this to the end of the list as this is the least important item.

* - If the min is a NaN, it should be ignored.
* - If the max is a NaN, it should be ignored.
* - If the min is +0, the row group may contain -0 values as well.
* - If the max is -0, the row group may contain +0 values as well.
*/
1: TypeDefinedOrder TYPE_ORDER;
}
Expand Down