PARQUET-1251: Clarify ambiguous min/max stats for FLOAT/DOUBLE #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@zivanfi, could you please check this out? |
zivanfi
reviewed
Mar 26, 2018
src/main/thrift/parquet.thrift
Outdated
| * | ||
| * (*) Because of the sorting order is not specified properly for floating | ||
| * point values (relations vs. total ordering) the following | ||
| * compatibility rules should be applied: |
Contributor
There was a problem hiding this comment.
Please add: "when reading statistics".
src/main/thrift/parquet.thrift
Outdated
| * (*) Because of the sorting order is not specified properly for floating | ||
| * point values (relations vs. total ordering) the following | ||
| * compatibility rules should be applied: | ||
| * - When looking for NaN values, min and max should be ignored. |
Contributor
There was a problem hiding this comment.
Please move this to the end of the list as this is the least important item.
Contributor
|
+1 Thanks for working on this @gszadovszky and @zivanfi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.