Skip to content
This repository was archived by the owner on May 10, 2024. It is now read-only.

PARQUET-1082: Change MutableBuffer to Buffer to account for deprecation in ARROW-1402 #384

Closed
wesm wants to merge 1 commit into from
Closed

PARQUET-1082: Change MutableBuffer to Buffer to account for deprecation in ARROW-1402 #384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/parquet/arrow/reader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ class PARQUET_NO_EXPORT StructImpl : public ColumnReader::Impl {
std::shared_ptr<Field> field_;
PoolBuffer def_levels_buffer_;

Status DefLevelsToNullArray(std::shared_ptr<MutableBuffer>* null_bitmap,
Status DefLevelsToNullArray(std::shared_ptr<Buffer>* null_bitmap,
int64_t* null_count);
void InitField(const NodePtr& node, const std::vector<std::shared_ptr<Impl>>& children);
};
Expand Down Expand Up @@ -1364,9 +1364,9 @@ Status ColumnReader::NextBatch(int batch_size, std::shared_ptr<Array>* out) {

// StructImpl methods

Status StructImpl::DefLevelsToNullArray(std::shared_ptr<MutableBuffer>* null_bitmap_out,
Status StructImpl::DefLevelsToNullArray(std::shared_ptr<Buffer>* null_bitmap_out,
int64_t* null_count_out) {
std::shared_ptr<MutableBuffer> null_bitmap;
std::shared_ptr<Buffer> null_bitmap;
auto null_count = 0;
ValueLevelsPtr def_levels_data;
size_t def_levels_length;
Expand Down Expand Up @@ -1448,7 +1448,7 @@ Status StructImpl::GetRepLevels(ValueLevelsPtr* data, size_t* length) {

Status StructImpl::NextBatch(int batch_size, std::shared_ptr<Array>* out) {
std::vector<std::shared_ptr<Array>> children_arrays;
std::shared_ptr<MutableBuffer> null_bitmap;
std::shared_ptr<Buffer> null_bitmap;
int64_t null_count;

// Gather children arrays and def levels
Expand Down