This repository was archived by the owner on May 10, 2024. It is now read-only.
PARQUET-1082: Change MutableBuffer to Buffer to account for deprecation in ARROW-1402 #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@xhochy @majetideepak given proximity of Arrow 0.7.0 I suggest that we upgrade to Arrow master and merge this patch, then we can release parquet-cpp 1.3.0 that is based on 0.7.0. Sound good? |
Member
|
@wesm I'm happy to merge this once we have an Arrow 0.7.0 release. I would then directly start the Parquet C++ release vote. |
|
Sounds good. Are we including PARQUET-1002 in the 1.3.0 release? #383 |
|
I also noticed that the Arrow master now requires additional boost system library dependency. I assume Parquet will now transitively require that as well? |
Member
Author
|
This has been true for a long time, at least since apache/arrow@d1a9aff#diff-6725b893dfc969abac4f4ee39a3a317fR864 It's only used for exception handling from boost/filesystem. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not merge this patch until after parquet-cpp 1.3.0 is released. Because these APIs have been deprecated, but not removed, the current trunk will build with both Arrow 0.6.0 and 0.7.0