Skip to content

Conversation

@maobaolong
Copy link
Member

@maobaolong maobaolong commented May 28, 2020

What changes were proposed in this pull request?

https://docs.google.com/document/d/1YfN5IOckveREuwFWJvWJNHnySo2qSqsQ0e_sxE7XatY/edit?usp=sharing

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3654

How was this patch tested?

➜  ozone-0.6.0-SNAPSHOT git:(factor2) ✗ bin/ozone admin pipeline list
Pipeline[ Id: ad2d3d4e-8794-4fcb-a494-d85c5231a000, Nodes: 2260916d-5e5d-40a5-b1b4-a4e706862f8a{ip: 127.0.0.1, host: localhost, networkLocation: /default-rack, certSerialId: null}3fedacd3-68bc-490f-aae1-0e0b7f08c640{ip: 127.0.0.1, host: localhost, networkLocation: /default-rack, certSerialId: null}478b0c68-cd20-49d0-a889-818624385053{ip: 127.0.0.1, host: localhost, networkLocation: /default-rack, certSerialId: null}, Type:RATIS, Factor:THREE, State:OPEN, leaderId:2260916d-5e5d-40a5-b1b4-a4e706862f8a, CreationTimestamp2020-05-28T13:53:35.124Z]
Pipeline[ Id: b93d3e71-79b7-453b-9574-3a787fd4a294, Nodes: 2260916d-5e5d-40a5-b1b4-a4e706862f8a{ip: 127.0.0.1, host: localhost, networkLocation: /default-rack, certSerialId: null}3fedacd3-68bc-490f-aae1-0e0b7f08c640{ip: 127.0.0.1, host: localhost, networkLocation: /default-rack, certSerialId: null}478b0c68-cd20-49d0-a889-818624385053{ip: 127.0.0.1, host: localhost, networkLocation: /default-rack, certSerialId: null}, Type:RATIS, Factor:THREE, State:OPEN, leaderId:478b0c68-cd20-49d0-a889-818624385053, CreationTimestamp2020-05-28T13:53:35.124Z]
Pipeline[ Id: cb38cb1e-155b-4a95-b593-2fce1867ee9f, Nodes: 478b0c68-cd20-49d0-a889-818624385053{ip: 127.0.0.1, host: localhost, networkLocation: /default-rack, certSerialId: null}3fedacd3-68bc-490f-aae1-0e0b7f08c640{ip: 127.0.0.1, host: localhost, networkLocation: /default-rack, certSerialId: null}, Type:RATIS, Factor:TWO, State:OPEN, leaderId:478b0c68-cd20-49d0-a889-818624385053, CreationTimestamp2020-05-28T13:53:32.693Z]
Pipeline[ Id: 525621c2-76d4-4637-8fac-3987fbf83deb, Nodes: 006fd0ff-a52c-4bdd-a888-e3a005828696{ip: 127.0.0.1, host: localhost, networkLocation: /default-rack, certSerialId: null}3fedacd3-68bc-490f-aae1-0e0b7f08c640{ip: 127.0.0.1, host: localhost, networkLocation: /default-rack, certSerialId: null}, Type:RATIS, Factor:TWO, State:OPEN, leaderId:3fedacd3-68bc-490f-aae1-0e0b7f08c640, CreationTimestamp2020-05-28T16:33:14.247Z]

Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my understanding it seems to be a harmless change. It's exactly the same logic as before but makes some experiment easier.

@nandakumar131 What do you think?

Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no objections I will merge it after the next full green build.

@maobaolong maobaolong closed this Aug 12, 2020
@maobaolong maobaolong reopened this Aug 12, 2020
@maobaolong maobaolong closed this Aug 12, 2020
@maobaolong maobaolong reopened this Aug 12, 2020
@maobaolong
Copy link
Member Author

@elek Thanks you for approve this PR, now it passed all CI checks.

@maobaolong maobaolong requested a review from elek August 24, 2020 08:34
@elek
Copy link
Member

elek commented Aug 25, 2020

Thanks the updated @maobaolong

FYI, it's easier to rerun the tests with an empty commit:

git commit --allow-empty -m "retrigger ci"
git push

(If I understood well you do close/open for the same reason...)

@elek elek merged commit c0084a1 into apache:master Aug 25, 2020
errose28 added a commit to errose28/ozone that referenced this pull request Aug 25, 2020
* master:
  HDDS-4111. Keep the CSI.zh.md consistent with CSI.md (apache#1320)
  HDDS-3654. Let backgroundCreator create pipeline for the support replication factors alternately (apache#984)
  HDDS-4112. Improve SCM webui page performance (apache#1323)
  HDDS-4074. [OFS] Implement AbstractFileSystem for RootedOzoneFileSystem (apache#1330)
  HDDS-4144. Update version info in hadoop client dependency readme (apache#1348)
  HDDS-4139. Update version number in upgrade tests (apache#1347)
rakeshadr pushed a commit to rakeshadr/hadoop-ozone that referenced this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants