Skip to content

Conversation

@ChenSammi
Copy link
Contributor

@ChenSammi
Copy link
Contributor Author

@elek @adoroszlai could you help to review the patch?

Copy link
Member

@elek elek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

I am not sure if we must update this README for all the releases. It's just a helper section to check the newly introduced dependencies in case of a version upgrade.

For example when whe upgrade to hadoop 3.3, we can compare the new dependencies to the reference one and check if any new dependencies are introduced. (In fact we can remove this part from the README).

But there is no problem with updating it (1.0.0 is nicer here ;-) )

@elek elek merged commit 28d372c into apache:ozone-1.0.0 Aug 25, 2020
elek pushed a commit that referenced this pull request Aug 25, 2020
@ChenSammi
Copy link
Contributor Author

I think the most important part of the readme is tell user how to find the dependencies using "mvn dependency:tree ". So we can position the left part(the command output) as an example, then there is no need to update it during every release.

errose28 added a commit to errose28/ozone that referenced this pull request Aug 25, 2020
* master:
  HDDS-4111. Keep the CSI.zh.md consistent with CSI.md (apache#1320)
  HDDS-3654. Let backgroundCreator create pipeline for the support replication factors alternately (apache#984)
  HDDS-4112. Improve SCM webui page performance (apache#1323)
  HDDS-4074. [OFS] Implement AbstractFileSystem for RootedOzoneFileSystem (apache#1330)
  HDDS-4144. Update version info in hadoop client dependency readme (apache#1348)
  HDDS-4139. Update version number in upgrade tests (apache#1347)
rakeshadr pushed a commit to rakeshadr/hadoop-ozone that referenced this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants