Skip to content

HDDS-13957. Snapshot needsDefrag should be set on upgrade when creating missing yaml files #9321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swamirishi merged 1 commit into from
Nov 18, 2025
+5 −0
Merged

HDDS-13957. Snapshot needsDefrag should be set on upgrade when creating missing yaml files #9321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,9 @@ private void addMissingSnapshotYamlFiles(
}
OmSnapshotLocalData snapshotLocalData = new OmSnapshotLocalData(snapshotId, sstList,
snapshotInfo.getPathPreviousSnapshotId(), null);
// Set needsDefrag to true to indicate that the snapshot needs to be defragmented, since the snapshot has
// never been defragmented before.
snapshotLocalData.setNeedsDefrag(true);
snapshotLocalDataSerializer.save(snapshotLocalDataFile, snapshotLocalData);
}
}
Expand Down
2 changes: 2 additions & 0 deletions ...ger/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOmSnapshotLocalDataManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,6 +1012,8 @@ public void testInitWithMissingYamlFiles(boolean needsUpgrade) throws IOExceptio
assertEquals(snapshotId, snapshotLocalData.getSnapshotId());
assertEquals(previousMap.get(snapshotId), snapshotLocalData.getPreviousSnapshotId());
assertEquals(expectedSstFile.get(snapshotId), snapshotLocalData.getVersionSstFileInfos());
assertTrue(readableOmSnapshotLocalDataProvider.needsDefrag());
assertTrue(snapshotLocalData.getNeedsDefrag());
}
}
} else {
Expand Down