Skip to content

HDDS-13957. Snapshot needsDefrag should be set on upgrade when creating missing yaml files#9321

Merged
swamirishi merged 1 commit intoapache:masterfrom
swamirishi:HDDS-13957
Nov 18, 2025
Merged

HDDS-13957. Snapshot needsDefrag should be set on upgrade when creating missing yaml files#9321
swamirishi merged 1 commit intoapache:masterfrom
swamirishi:HDDS-13957

Conversation

@swamirishi
Copy link
Contributor

What changes were proposed in this pull request?

Currently on upgrade when initializing OmSnapshotLocalDataManager the needsDefrag flag is not set which should be set since the snapshot can never get defragged ever.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-13957

How was this patch tested?

Added unit test

…ng missing yaml files

Change-Id: I36644d2f95d411beafc5e064f520c2cd9ec0745c
@swamirishi swamirishi added the snapshot https://issues.apache.org/jira/browse/HDDS-6517 label Nov 18, 2025
Copy link
Contributor

@sadanand48 sadanand48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending ci

@swamirishi swamirishi marked this pull request as ready for review November 18, 2025 12:38
@swamirishi swamirishi merged commit 9bb1898 into apache:master Nov 18, 2025
55 checks passed
@swamirishi
Copy link
Contributor Author

thanks @sadanand48 for reviewing the patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

snapshot https://issues.apache.org/jira/browse/HDDS-6517

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants