Skip to content

HDDS-13936. Replace Thread.sleep with waitFor in TestContainerBalancerOperations #9302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adoroszlai merged 2 commits into from
Nov 18, 2025
Merged

HDDS-13936. Replace Thread.sleep with waitFor in TestContainerBalancerOperations #9302

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1882a5d
Replace Thread.sleep with proper waiting mechanism for Container Bala…
Nov 16, 2025
e069eef
remove redundant part
rich7420 Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions ...tegration-test/src/test/java/org/apache/hadoop/ozone/TestContainerBalancerOperations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import org.apache.hadoop.hdds.scm.client.ScmClient;
import org.apache.hadoop.hdds.scm.container.balancer.ContainerBalancerConfiguration;
import org.apache.hadoop.hdds.scm.container.placement.algorithms.SCMContainerPlacementCapacity;
import org.apache.ozone.test.GenericTestUtils;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -97,15 +98,17 @@ public void testContainerBalancerCLIOperations() throws Exception {
running = containerBalancerClient.getContainerBalancerStatus();
assertTrue(running);

// waiting for balance completed.
// TODO: this is a temporary implementation for now
// modify this after balancer is fully completed
try {
Thread.sleep(20000);
} catch (InterruptedException e) { }

running = containerBalancerClient.getContainerBalancerStatus();
assertFalse(running);
GenericTestUtils.waitFor(
() -> {
try {
return !containerBalancerClient.getContainerBalancerStatus();
} catch (IOException e) {
return false;
}
},
100,
30000
);

// test normally start , and stop it before balance is completed
containerBalancerClient.startContainerBalancer(threshold, iterations,
Expand Down