HDDS-13936. Replace Thread.sleep with waitFor in TestContainerBalancerOperations#9302
Merged
adoroszlai merged 2 commits intoapache:masterfrom Nov 18, 2025
Merged
HDDS-13936. Replace Thread.sleep with waitFor in TestContainerBalancerOperations#9302adoroszlai merged 2 commits intoapache:masterfrom
adoroszlai merged 2 commits intoapache:masterfrom
Conversation
rich7420
changed the title
sarvekshayr
reviewed
Nov 17, 2025
Contributor
sarvekshayr
left a comment
sarvekshayr
left a comment
There was a problem hiding this comment.
Thanks @rich7420. Overall LGTM.
Just a minor comment below -
.../integration-test/src/test/java/org/apache/hadoop/ozone/TestContainerBalancerOperations.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@sarvekshayr thanks for the feedback! |
adoroszlai
changed the title
sarvekshayr
approved these changes
Nov 18, 2025
Contributor
|
Thanks @rich7420 for the patch, @chungen0126, @sarvekshayr for the review. |
Contributor
Author
|
Thanks @sarvekshayr , @chungen0126 and @adoroszlai ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR removed the TODO comment as it's now completed.
This PR modified
TestContainerBalancerOperations.javato replaceThread.sleep(20000)withGenericTestUtils.waitFor().What is the link to the Apache JIRA
Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull
request which starts with the corresponding JIRA issue number. (e.g. HDDS-XXXX. Fix a typo in YYY.)
HDDS-13936
How was this patch tested?
https://github.com/rich7420/ozone/actions/runs/19402653019