HDDS-13887. [STS] Protobuf Plumbing for AssumeRole Requests #9254
Conversation
sodonnel
left a comment
sodonnel
left a comment
There was a problem hiding this comment.
This change LGTM. Its basically all boiler plate code to wire up the new request and protobuf stuff.
If CI passes and you are happy with fields etc we can commit onto the branch.
| public AssumeRoleResponseInfo assumeRole(String roleArn, | ||
| String roleSessionName, | ||
| int durationSeconds, | ||
| String awsIamSessionPolicy) throws IOException { |
There was a problem hiding this comment.
Please do not format method signatures like this. Whenever visibility / return type / method name / other modifiers are changed, we would have to reindent all parameters.
(The same comment applies to other files.)
There was a problem hiding this comment.
The style guide says you should indent 4 spaces rather than align at the bracket for this reason. Many method definitions in Ozone fill the line length with parameters on the same line, which is less readable IMO.
I would be nice if checkstyle could enforce this, but I suspect there are a lot of violations across the code base if we turned it on!
There was a problem hiding this comment.
4 participants
Please describe your PR in detail:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13887
How was this patch tested?
Unit tests