HDDS-13088. Checkstyle: reject too large indentation in wrapped lines

[swamirishi]

What changes were proposed in this pull request?

Disable multiline alignment for function definitions in the checkstyle configuration

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-13088

How was this patch tested?

No unit tests required only checkstyle changes

[adoroszlai]

Thanks @swamirishi for the patch. I think existing code uses different value.

[adoroszlai]

Default value of lineWrappingIndentation is 4, so I'm not sure this change will make any difference.

What we need is forceStrictCondition=true to disallow indents more than 4. But it will also require fixing indentation in existing code.

Force strict indent level in line wrapping case. If value is true, line wrap indent have to be same as lineWrappingIndentation parameter. If value is false, line wrap indent could be bigger on any value user would like.

[adoroszlai]

No unit tests required only checkstyle changes

The question is more generic than just unit tests. For a checkstyle change:

• confirm that checkstyle check passes
• introduce violation (locally or in test branch) to verify that checkstyle catches it

[adoroszlai]

I have tried adding forceStrictCondition=true: it will introduce 17K violations. So we'll need to make the change gradually.