HDDS-13294. Remove the Table.close() method. #8658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarvekshayr
approved these changes
Jun 19, 2025
Contributor
sarvekshayr
left a comment
sarvekshayr
left a comment
There was a problem hiding this comment.
Thanks for the patch @szetszwo. LGTM
adoroszlai
reviewed
Jun 20, 2025
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @szetszwo for the patch.
Comment on lines
308
to
312
| try { | ||
| if (pipelineStore != null) { | ||
| pipelineStore.close(); | ||
| pipelineStore = null; | ||
| } | ||
| } catch (Exception ex) { |
Contributor
There was a problem hiding this comment.
nit: try-catch and if no longer needed.
Contributor
Author
There was a problem hiding this comment.
I actually want to remove the close() method. Unfortunately, it is not easy to do.
adoroszlai
approved these changes
Jun 20, 2025
Contributor
Author
|
Thanks @sarvekshayr and @adoroszlai for reviewing this! |
aswinshakil
added a commit
to aswinshakil/ozone
that referenced
this pull request
Jun 23, 2025
…239-container-reconciliation Commits: 9 05567e6 HDDS-13317. Table should support empty array/String (apache#8676) 803fa31 HDDS-13313. Bump maven-javadoc-plugin to 3.11.2 (apache#8672) 774b3ee HDDS-13315. Bump log4j2 to 2.25.0 (apache#8670) b86fad8 HDDS-13316. Bump commons-text to 1.13.1 (apache#8669) c043be7 HDDS-13312. Bump maven-patch-plugin to 1.3 (apache#8673) db6ed84 HDDS-13294. Remove the Table.close() method. (apache#8658) e1365a7 HDDS-13286. Fail stream write when the volume is full. (apache#8644) af3a0f0 HDDS-13307. integration (flaky) fails with all tests passing (apache#8667) d207c18 HDDS-13301. Fix TestSchemaOneBackwardsCompatibility (apache#8666) Conflicts: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/ContainerUtils.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
All the implementations of the Table.close() method are noop. We should remove it.
The patch of this PR is quite big due to the try-with-resource change for auto-closing Table.
What is the link to the Apache JIRA
HDDS-13294
How was this patch tested?
By existing tests.