HDDS-12053. Make print-log-dag command run locally and offline #8016

Tejaskriya · 2025-03-05T22:21:02Z

What changes were proposed in this pull request?

ozone debug print-log-dag has a few implementation issues:

The command goes over the network, but writes the resulting graph locally to the server
The command requires the OM to be online, which may not be the case if it has crashed or we are examining disk state we received from a cluster we cannot access

Like other debug commands, This PR makes make this run only on the disk state present on OM. The OM process may be running while this is happening, but this is not required.

Most of the changes are of code refactoring to reduce code duplication between the command and RocksDBCheckpointDiffer.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-12053

How was this patch tested?

Existing tests for the refactored code.
For the command, tested manually using the tools jar created.

Usage: ozone debug om generate-compaction-dag [-hV] [--verbose] --db=<dbPath>
       -o=<imageLocation>
Create an image of the current compaction log DAG. This command is an offline
command. i.e., it can run on any instance of om.db and does not require OM to
be up.
      --db=<dbPath>   Path to OM RocksDB
  -h, --help          Show this help message and exit.
  -o, --output-file=<imageLocation>
                      Path to location at which image will be downloaded.
                        Should include the image file name with ".png"
                        extension.
  -V, --version       Print version information and exit.
      --verbose       More verbose output. Show the stack trace of the errors.

The dag is obtained:

$ ozone debug om gcd --db=/home/tmp/metadata/om.db -o=/home/Desktop/dag-try-4.png
Graph was generated at '/home/Desktop/dag-try-4.png'.

adoroszlai

Thanks @Tejaskriya for the patch.

...ksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java

...checkpoint-differ/src/main/java/org/apache/ozone/compaction/log/PopulateCompactionTable.java

hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/om/CompactionLogDagPrinter.java

Tejaskriya · 2025-03-07T08:16:41Z

@adoroszlai thank you for the review! I have addressed all of the comments

adoroszlai

Thanks @Tejaskriya for updating the patch.

hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/om/CompactionLogDagPrinter.java

hemantk-12

Thanks, @Tejaskriya for working on this improvement.

Rather than providing a util class, I would prefer to wrap MutableGraph and provide functions to add/remove input/output file nodes.

hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/om/CompactionLogDagPrinter.java

...ksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java

...checkpoint-differ/src/main/java/org/apache/ozone/compaction/log/PopulateCompactionTable.java

hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/CompactionLogDagPrinter.java

Tejaskriya · 2025-03-12T08:52:15Z

@hemantk-12 The util class I had added PopulateCompactionTable was for the backward compatibility point you have mentioned above, all the methods in that class are for parsing the log file and adding it to the rocksDB compactionLogTable. It doesn't deal with the graph creation aspect of the command.

For the methods to add/remove input/output file nodes, I have created the methods in CompactionLogDagPrinter itself. It can be moved to PrintableGraph but the patch size would increase even more as it will need refactoring in RocksDBCheckpointDiffer, PrintableGraph, CompactionLogDagPrinter. I suggest to have a follow-up jira which refactors the graph related method. Would that be okay?

...sdb-checkpoint-differ/src/main/java/org/apache/ozone/compaction/log/CompactionDagHelper.java

hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/om/CompactionLogDagPrinter.java

...s/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/compaction/log/RocksDBConsts.java

...ksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java

hemantk-12 · 2025-03-28T17:22:20Z

...sdb-checkpoint-differ/src/main/java/org/apache/ozone/compaction/log/CompactionDagHelper.java

+/**
+ * Utility methods to populate compactionLogTable from a compaction-log file.
+ */
+public final class CompactionDagHelper {


I initially thought this was just helper code in the draft version of the patch, but now it seems to be more than that.
Can we consider it merely a wrapper over the compaction-log table? If so, I will rename it to CompactionLogTable and keep only minimal functions, such as adding and removing an entry from the table.

I had added this for compactionFile related utility methods. As now we are not including that, I have removed this

But now, we have duplicated code.

I think we should do something like this: hemantk-12@ecf3d0f#diff-332b998c05d99c645df628b01e2b3fc94ce540b5d3c73ed348c3c9e605e57bcbR6-R36

hemantk-12 · 2025-03-28T17:44:28Z

hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/om/CompactionLogDagPrinter.java

+
+      loadAllCompactionLogs();
+
+      PrintableGraph graph;


Can you move graph to tools package and deprecate the PrintCompactionLogDag API and related code?

In order to deprecate the APIs, I have added the @deprecated annotation. Didn't make any changes on OM server side to keep compatibility. Because of that I couldn't move the graph dir to tools as it is being used in RocksDBCheckpointDiffer.
Is there any other way to correctly deprecate this?

Since it is an ops tool, IOM, it is OK if you just throw an exception and remove the older implementation in OzoneManager and OzoneManagerProtocolClientSideTranslatorPB. Change the exception message in OzoneManagerProtocol.

Okay, I have changed it as you have suggested. Could you please take a look again?

Can you please do the following as well?

Mark printCompactionLogDag deprecated.

Remove it form RpcClient, ClientProtocol and ObjectStore.

hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OmUtils.java

hemantk-12 · 2025-04-02T20:48:35Z

hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/om/CompactionLogDagPrinter.java

+
+      loadAllCompactionLogs();
+
+      PrintableGraph graph;


Since it is an ops tool, IOM, it is OK if you just throw an exception and remove the older implementation in OzoneManager and OzoneManagerProtocolClientSideTranslatorPB. Change the exception message in OzoneManagerProtocol.

hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/om/CompactionLogDagPrinter.java

hemantk-12 · 2025-04-02T23:42:42Z

...sdb-checkpoint-differ/src/main/java/org/apache/ozone/compaction/log/CompactionDagHelper.java

+/**
+ * Utility methods to populate compactionLogTable from a compaction-log file.
+ */
+public final class CompactionDagHelper {


But now, we have duplicated code.

Tejaskriya · 2025-04-22T04:04:45Z

@hemantk-12 , I have done the additional refactoring as you have suggested. Could you please take a look again?

hemantk-12

Thanks @Tejaskriya for addressing the review comments.
I left a few more comments. Please tale a look.

...p-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/CompactionDag.java

...ksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java

hemantk-12 · 2025-04-22T19:36:12Z

...ksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java

  @VisibleForTesting
  public ConcurrentHashMap<String, CompactionNode> getCompactionNodeMap() {
-    return compactionNodeMap;
+    return (ConcurrentHashMap<String, CompactionNode>) compactionDag.getCompactionMap();


It is Ok to return like this in this patch, but we should do a clean-up and use CompactionDag as encapsulation.

IMO this method should be rewritten as ConcurrentMap.
In general, returning more abstract type is preferred, as it avoid a lot of unnecessary code change later, just like this.

Tejaskriya · 2025-04-24T07:18:22Z

Thanks for the review @hemantk-12 , I have addressed all the comments. If the new changes look good could you please approve the PR?

hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/om/CompactionLogDagPrinter.java

hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/graph/Edge.java

hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/om/CompactionLogDagPrinter.java

hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/om/OMDebug.java

hadoop-ozone/tools/src/test/java/org/apache/hadoop/ozone/graph/TestPrintableGraph.java

adoroszlai · 2025-04-29T10:47:51Z

hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/client/ClientProtocolStub.java

  }

  @Override
+  @Deprecated


Is it enough to add @Deprecated in the interface, and not all implementations?

I have added it to all places where I saw the annotation was used. Some server side code for it was entirely removed as for this command we don't it to be compatible.
Cross checked with a few other PRs which deprecated some APIs.

Followed @hemantk-12 's suggestion from here

Tejaskriya · 2025-04-30T09:23:19Z

Thanks for the review @adoroszlai , I have made the suggestions as you suggested. Could you please take a look at it again?

adoroszlai

Thanks @Tejaskriya for updating the patch.

hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/om/PrefixParser.java

...p-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/CompactionDag.java

adoroszlai

Thanks @Tejaskriya for updating the patch, LGTM. Let me know if you would like someone familiar with snapshots take another look or if you think we can merge this.

Tejaskriya · 2025-05-05T06:33:33Z

@adoroszlai thanks for the review
@hemantk-12 reviewed this multiple rounds, and the last round had some minor comments only. I think we are good to merge this from snapshot point of view.

But @jojochuang self-request a review a few days ago, Would you like to take a look?

jojochuang

LGTM

jojochuang · 2025-05-05T19:33:09Z

...-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/CompactionNode.java

  private final String endKey;
  private final String columnFamily;

-  /**


perhaps we should keep the javadoc for the constructor?

jojochuang · 2025-05-05T20:10:31Z

Thanks for the PR @Tejaskriya and review comments from @adoroszlai @hemantk-12 @errose28 !

Tejaskriya · 2025-05-06T04:31:24Z

Thanks for the review and merge @jojochuang . I have addressed the couple of comments in this PR

…e#8016)

…239-container-reconciliation Commits: 113 commits 8ceb5c3 Revert "HDDS-11232. Spare InfoBucket RPC call for the FileSystem#getFileStatus calls for the general case. (apache#6988)" (apache#8358) 8ecf4a8 HDDS-12993. Use DatanodeID in ReconNodeManager. (apache#8456) 3e09a11 HDDS-13024. HTTP connect to 0.0.0.0 failed (apache#8439) c3cb14f HDDS-12914. Bump awssdk to 2.31.40, test ResumableFileDownload (apache#8455) c6b47e9 HDDS-4677. Document Ozone Ports and Connection End Points (apache#8226) ae0d757 HDDS-13044. Remove DatanodeDetails#getUuid usages from hdds-common/client/container-service (apache#8462) 2bf3f16 HDDS-12568. Implement MiniOzoneCluster.Service for Recon (apache#8452) e59d251 HDDS-13046. Add .vscode to .gitignore (apache#8461) 50e6d61 HDDS-13022. Split up exclusive size tracking for key and directory cleanup in SnapshotInfo (apache#8433) 6db647d HDDS-12966. DBDefinitionFactory should not throw InvalidArnException (apache#8454) fe2875c HDDS-12948. [Snapshot] Increase `ozone.om.fs.snapshot.max.limit` default value to 10k (apache#8376) 215bdc2 HDDS-11904. Fix HealthyPipelineSafeModeRule logic. (apache#8386) dba7557 HDDS-12989. Throw CodecException for the Codec byte[] methods (apache#8444) d9c73f0 HDDS-11298. Support owner field in the S3 listBuckets request (apache#8315) 7a5129d HDDS-12810. Check and reserve space atomically in VolumeChoosingPolicy (apache#8360) d51ccf7 HDDS-13016. Add a getAllNodeCount() method to NodeManager. (apache#8445) 8b27fb9 HDDS-12299. Merge OzoneAclConfig into OmConfig (apache#8383) 96f4f79 HDDS-12501. Remove OMKeyInfo from SST files in backup directory. (apache#8214) 8adb500 HDDS-13021. Make callId unique for each request in AbstractKeyDeletingService (apache#8432) faeadd6 HDDS-13000. [Snapshot] listSnapshotDiffJobs throws NPE. (apache#8418) 7c957cc HDDS-11954. List keys command gets wrong info from BasicOmKeyInfo (apache#8401) 0697383 HDDS-13027. Workaround for GitHub connection failures (apache#8443) 0d5f933 HDDS-12919. Remove redundant FileLock from ChunkWrite (apache#8435) 395892a HDDS-13012. [Snapshot] Add audit logs for listSnapshotDiffJobs, snapshotDiff and cancelSnapshotDiff. (apache#8425) d92f0ed HDDS-12653. Add option in `ozone debug log container list` to filter by Health State (apache#8415) 78f8a02 HDDS-12645. Improve output of `ozone debug replicas chunk-info` (apache#8146) f32470c HDDS-12995. Split ListOptions for better reuse (apache#8413) cdd1b13 HDDS-13019. Bump jline to 3.30.0 (apache#8428) 1651408 HDDS-13018. Bump common-custom-user-data-maven-extension to 2.0.2 (apache#8429) 8f6222e HDDS-12949. Cleanup SCMSafeModeManager (apache#8390) adb385f HDDS-13002. Use DatanodeID in ContainerBalancerTask (apache#8421) 2b2a796 HDDS-12969. Use DatanodeID in XceiverClientGrpc (apache#8430) 3c0bafa HDDS-13001. Use DatanodeID in SCMBlockDeletingService. (apache#8420) 8448bc2 HDDS-12187. Use hadoop-dependency-client as parent, not dependency (apache#8416) 582fd03 HDDS-13015. Bump zstd-jni to 1.5.7-3 (apache#8426) ec12f98 HDDS-12970. Use DatanodeID in Pipeline (apache#8414) 3f48a18 HDDS-12179. Improve Container Log to also capture the Volume Information (apache#7858) 034b497 HDDS-12964. Add minimum required version of Docker Compose to RunningViaDocker page (apache#8385) c0a6b42 HDDS-12947. Add CodecException (apache#8411) 70949c5 HDDS-11603. Reclaimable Key Filter for Snapshots garbage reclaimation (apache#8392) 08283f3 HDDS-12087. TransactionToDNCommitMap too large causes GC to pause for a long time (apache#8347) f47df78 HDDS-12958. [Snapshot] Add ACL check regression tests for snapshot operations. (apache#8419) 1cc8445 HDDS-12207. Unify output of ozone debug replicas verify checks (apache#8248) f087d0b HDDS-12994. Use DatanodeID in ReconSCMDBDefinition. (apache#8417) d6a7723 HDDS-12776. ozone debug CLI command to list all Duplicate open containers (apache#8409) c78aeb0 HDDS-12951. EC: Log when falling back to reconstruction read (apache#8408) 412f22d HDDS-12959. Eliminate hdds-hadoop-dependency-server (apache#8384) df701dc HDDS-12996. Workaround for Docker Compose concurrent map writes (apache#8412) e6daae4 HDDS-12972. Use DatanodeID in ContainerReplica. (apache#8396) c1103ae HDDS-12877. Support StorageClass field in the S3 HeadObject request (apache#8351) 4135384 HDDS-12973. Add javadoc for CompactionNode() and make getCompactionNodeGraph return ConcurrentMap (apache#8395) 4f2e13c HDDS-12954. Do not throw IOException for checksum. (apache#8387) 49b8fbd HDDS-12971. Use DatanodeID in Node2PipelineMap (apache#8403) d2da18f HDDS-12346. Reduce code duplication among TestNSSummaryTask classes (apache#8287) 82b73e3 HDDS-11856. Set DN state machine thread priority higher than command handler thread. (apache#8253) d4f2734 HDDS-12689. Import BOM for AWS SDK, declare dependencies (apache#8406) 4775e76 HDDS-12975. Fix percentage of blocks deleted in grafana dashboard (apache#8398) ac0d696 HDDS-12968. [Recon] Fix column visibility issue in Derby during schema upgrade finalization. (apache#8393) e71dcf6 HDDS-11981. Add annotation for registering feature validator based on a generic version (apache#7603) 254297c HDDS-12562. Reclaimable Directory entry filter for reclaiming deleted directory entries (apache#8055) 4f467c8 HDDS-12978. Remove TestMultipartObjectGet (apache#8400) a99f207 HDDS-12967. Skip CommonChunkManagerTestCases.testFinishWrite if fuser cannot be started (apache#8389) d29d76b HDDS-12697. Ozone debug CLI to display details of a single container (apache#8264) 1d1bc88 HDDS-12974. Docker could not parse extra host IP (apache#8397) 7e675d7 HDDS-12053. Make print-log-dag command run locally and offline (apache#8016) d3faab3 HDDS-12561. Reclaimable Rename entry filter for reclaiming renaming entries (apache#8054) af1f98c HDDS-10822. Tool to omit raft log in OM. (apache#8154) 3201ca4 HDDS-12952. Make OmSnapshotManager#snapshotLimitCheck thread-safe and consistent (apache#8381) 522c88d HDDS-12963. Clean up io.grpc dependencies (apache#8382) fa8bd9d HDDS-12916. Support ETag in listObjects response (apache#8356) fdc77db HDDS-12300. Merge OmUpgradeConfig into OmConfig (apache#8378) 623e144 HDDS-12956. Bump vite to 4.5.14 (apache#8375) 8c8eaf1 HDDS-12944. Reduce timeout for integration check (apache#8374) 40d2e00 HDDS-11141. Avoid log flood due due pipeline close in XceiverServerRatis (apache#8325) 9fe1dba HDDS-12942. Init layout version config should not be public (apache#8373) 452e7aa HDDS-12596. OM fs snapshot max limit is not enforced (apache#8377) 8b095d5 HDDS-12795. Rename heartbeat and first election configuration name (apache#8249) bee8164 HDDS-12920. Configure log4j to gzip rolled over service log files (apache#8357) e16a50f HDDS-12934. Split submodule for Freon. (apache#8367) b1e9511 HDDS-12925. Update datanode volume used space on container deletion (apache#8364) 440bc82 Revert "HDDS-12596. OM fs snapshot max limit is not enforced (apache#8157)" f345492 HDDS-12596. OM fs snapshot max limit is not enforced (apache#8157) ee7b1dc HDDS-12901. Introduce EventExecutorMetrics instead of setting the metrics props unsafely (apache#8371) 810e148 HDDS-12939. Remove UnknownPipelineStateException. (apache#8372) 560fcdf HDDS-12728. Add Ozone 2.0.0 to compatibility acceptance tests (apache#8361) 5815a47 HDDS-12933. Remove the table names declared in OmMetadataManagerImpl (apache#8370) ee32fa5 HDDS-12560. Reclaimable Filter for Snaphost Garbage Collections (apache#8053) 45374ea HDDS-12932. Rewrite OMDBDefinition (apache#8362) 5cb6dd8 HDDS-12575. Set default JUnit5 timeout via property (apache#8348) 8efc0cd HDDS-11633. Delete message body too large, causing SCM to fail writing raft log (apache#8354) ac9d9fd HDDS-12915. Intermittent failure in testCreatePipelineThrowErrorWithDataNodeLimit (apache#8359) 86039e8 HDDS-12848. Create new submodule for ozone admin (apache#8292) 2d0f8cb HDDS-12833. Remove the CodecRegistry field from DBStoreBuilder (apache#8327) c71b393 HDDS-12921. UnusedPrivateField violations in tests (apache#8353) 9f3dd01 HDDS-12917. cp: option '--update' doesn't allow an argument (apache#8346) a14b395 HDDS-12922. Use OMDBDefinition in GeneratorOm and FSORepairTool (apache#8355) c8a98d6 HDDS-12892. OM Tagging Request incorrectly sets full path as key name for FSO (apache#8345) ade69e3 HDDS-12649. Include name of volume or bucket in length validation error (apache#8322) c68308d HDDS-12599. Create an ozone debug CLI command to list all the containers based on final state (apache#8282) 319d5a4 HDDS-12773. bad substitution in bats test (apache#8290) 6f5e02a HDDS-12900. (addendum: fix pmd) Use OMDBDefinition in OmMetadataManagerImpl (apache#8337) 2a7000d HDDS-12900. Use OMDBDefinition in OmMetadataManagerImpl (apache#8337) 9c0c66c HDDS-12915. Mark testCreatePipelineThrowErrorWithDataNodeLimit as flaky a73e052 HDDS-12907. Enable FieldDeclarationsShouldBeAtStartOfClass PMD rule (apache#8344) d083f82 HDDS-12905. Move field declarations to start of class in ozone-common (apache#8342) 3f90e1c HDDS-12906. Move field declarations to start of class in ozone-manager module (apache#8343) 403fb97 HDDS-12878. Move field declarations to start of class in tests (apache#8308) 63d5c73 HDDS-12912. Remove deprecated `PipelineManager#closePipeline(Pipeline, boolean)` (apache#8340) cf1fb88 HDDS-12902. Shutdown executor in CloseContainerCommandHandler and ECReconstructionCoordinator (apache#8341) 825ba02 HDDS-9585. Improve import/export log in ContainerLogger (apache#8330) b70d35a HDDS-12889. Enable AppendCharacterWithChar PMD rule (apache#8324) cd308ea HDDS-12904. Move field declarations to start of class in other hdds modules (apache#8336) 4905286 HDDS-12899. Move field declarations to start of class in hdds-server-scm (apache#8332) Conflicts: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/ContainerLogger.java hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestKeyValueHandler.java hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerReplica.java hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/container/ReconcileSubcommand.java hadoop-ozone/recon-codegen/src/main/java/org/apache/ozone/recon/schema/ContainerSchemaDefinition.java

adoroszlai reviewed Mar 6, 2025

View reviewed changes

errose28 added the tools Tools that helps with debugging label Mar 6, 2025

errose28 requested a review from hemantk-12 March 6, 2025 15:17

adoroszlai reviewed Mar 7, 2025

View reviewed changes

errose28 reviewed Mar 10, 2025

View reviewed changes

hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/om/CompactionLogDagPrinter.java Outdated Show resolved Hide resolved

hemantk-12 reviewed Mar 10, 2025

View reviewed changes

Tejaskriya requested a review from hemantk-12 March 12, 2025 11:37

hemantk-12 reviewed Mar 28, 2025

View reviewed changes

Tejaskriya force-pushed the offlinePLDCommand branch from b887afa to fb676d7 Compare April 2, 2025 08:33

Tejaskriya requested review from errose28 and hemantk-12 April 2, 2025 09:13

Tejaskriya added 3 commits April 2, 2025 18:44

HDDS-12053. Make print-log-dag command run locally and offline

f606e45

deprecate printlogdag APIs

23e7606

shift test helpers to test code

7f1da73

Tejaskriya force-pushed the offlinePLDCommand branch from 92e3f14 to 7f1da73 Compare April 2, 2025 13:15

hemantk-12 reviewed Apr 2, 2025

View reviewed changes

Tejaskriya added 3 commits April 4, 2025 14:00

refactor graph directory and remove server side code

7253914

remove numKeys

268c970

Refactor compaction dag creation code to reduce duplication

49eadd4

Tejaskriya requested a review from hemantk-12 April 7, 2025 05:16

Refactor compaction dag creation code to CompactionDagHelper

1f9dbcd

hemantk-12 force-pushed the offlinePLDCommand branch from ecf3d0f to 1f9dbcd Compare April 7, 2025 22:24

Refactor compaction dag and rocksDBcheckpointDiffer

0e37db7

Tejaskriya marked this pull request as draft April 17, 2025 14:48

Tejaskriya and others added 3 commits April 17, 2025 20:44

Code cleanup

f25ffce

Merge branch 'master' into offlinePLDCommand

d54048e

Fix merge issues

b8285a8

Tejaskriya marked this pull request as ready for review April 22, 2025 04:04

hemantk-12 reviewed Apr 22, 2025

View reviewed changes

Change java docs and add getCompactionNode helper method

7747d06

Tejaskriya requested a review from hemantk-12 April 24, 2025 07:18

Tejaskriya added 2 commits April 25, 2025 10:44

Merge remote-tracking branch 'origin' into offlinePLDCommand

546764c

Checkstyle fix

638a3bd

adoroszlai reviewed Apr 29, 2025

View reviewed changes

jojochuang self-requested a review April 30, 2025 05:37

Tejaskriya added 2 commits April 30, 2025 13:01

Refactor graph package, move db option to parent

2657edf

Merge remote-tracking branch 'origin' into offlinePLDCommand

c74e907

adoroszlai reviewed Apr 30, 2025

View reviewed changes

hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/om/PrefixParser.java Outdated Show resolved Hide resolved

...p-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/CompactionDag.java Outdated Show resolved Hide resolved

Fix method indendations and remove setDB()

07809ea

Tejaskriya requested a review from adoroszlai May 2, 2025 04:21

adoroszlai reviewed May 5, 2025

View reviewed changes

jojochuang approved these changes May 5, 2025

View reviewed changes

jojochuang merged commit 7e675d7 into apache:master May 5, 2025
42 checks passed

Tejaskriya mentioned this pull request May 6, 2025

HDDS-12973. Add java doc for CompactionNode constructor and make getCompactionNodeGraph return ConcurrentMap #8395

Merged

vtutrinov pushed a commit to vtutrinov/ozone that referenced this pull request May 13, 2025

HDDS-12053. Make print-log-dag command run locally and offline (apach…

aa25677

…e#8016)

HDDS-12053. Make print-log-dag command run locally and offline #8016

HDDS-12053. Make print-log-dag command run locally and offline #8016

Uh oh!

Conversation

Tejaskriya commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

What is the link to the Apache JIRA

How was this patch tested?

Uh oh!

adoroszlai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Tejaskriya commented Mar 7, 2025

Uh oh!

adoroszlai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hemantk-12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Tejaskriya commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hemantk-12 Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Tejaskriya commented Apr 22, 2025

Uh oh!

hemantk-12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Tejaskriya commented Apr 24, 2025

Tejaskriya commented Mar 5, 2025 •

edited

Loading

Tejaskriya commented Mar 12, 2025 •

edited

Loading

hemantk-12 Apr 7, 2025 •

edited

Loading