Skip to content

HDDS-12184. Enhance NSSummaryTask process() for Faster Processing. #7795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ArafatKhan2198 wants to merge 1 commit into from
Closed

HDDS-12184. Enhance NSSummaryTask process() for Faster Processing. #7795

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 28 additions & 12 deletions hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,21 +101,37 @@ public String getTaskName() {
@Override
public Pair<String, Boolean> process(OMUpdateEventBatch events) {
long startTime = System.currentTimeMillis();
boolean success = nsSummaryTaskWithFSO.processWithFSO(events);
if (!success) {
LOG.error("processWithFSO failed.");
}
success = nsSummaryTaskWithLegacy.processWithLegacy(events);
if (!success) {
LOG.error("processWithLegacy failed.");
}
success = nsSummaryTaskWithOBS.processWithOBS(events);
if (!success) {
LOG.error("processWithOBS failed.");

// Thread pool to execute tasks concurrently
ExecutorService executorService = Executors.newFixedThreadPool(3);
Copy link
Contributor

@adoroszlai adoroszlai Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating a thread pool is heavy-weight, it should be reused.


// Create a list of tasks
List<Callable<Boolean>> tasks = new ArrayList<>();
tasks.add(() -> nsSummaryTaskWithFSO.processWithFSO(events));
tasks.add(() -> nsSummaryTaskWithLegacy.processWithLegacy(events));
tasks.add(() -> nsSummaryTaskWithOBS.processWithOBS(events));

try {
// Execute all tasks in parallel
List<Future<Boolean>> results = executorService.invokeAll(tasks);

// Check results and return failure if any task failed
for (Future<Boolean> result : results) {
if (!result.get()) {
LOG.error("One or more process tasks failed.");
return new ImmutablePair<>(getTaskName(), false);
Copy link
Contributor

@adoroszlai adoroszlai Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for all results before returning.

}
}
} catch (InterruptedException | ExecutionException e) {
LOG.error("Error executing process tasks in parallel", e);
return new ImmutablePair<>(getTaskName(), false);
} finally {
executorService.shutdown();
}
LOG.debug("{} successfully processed in {} milliseconds",
getTaskName(), (System.currentTimeMillis() - startTime));
return new ImmutablePair<>(getTaskName(), success);

return new ImmutablePair<>(getTaskName(), true);
}

@Override
Expand Down