HDDS-12184. Enhance NSSummaryTask process() for Faster Processing. #7795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Feb 3, 2025
| LOG.error("processWithOBS failed."); | ||
|
|
||
| // Thread pool to execute tasks concurrently | ||
| ExecutorService executorService = Executors.newFixedThreadPool(3); |
Contributor
There was a problem hiding this comment.
Creating a thread pool is heavy-weight, it should be reused.
| for (Future<Boolean> result : results) { | ||
| if (!result.get()) { | ||
| LOG.error("One or more process tasks failed."); | ||
| return new ImmutablePair<>(getTaskName(), false); |
Contributor
There was a problem hiding this comment.
Wait for all results before returning.
Contributor
|
/pending |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Thank you very much for the patch. I am closing this PR temporarily as there was no activity recently and it is waiting for response from its author. It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time. It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs. If you need ANY help to finish this PR, please contact the community on the mailing list or the slack channel." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We can parallelize the
process()method inNSSummaryTasksimilarly to how reprocess() was parallelized. Instead of runningprocessWithFSO(),processWithLegacy(), andprocessWithOBS()sequentially, we can execute them concurrently using an ExecutorService.We will :-
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12184
How was this patch tested?
Manually Tested