-
Notifications
You must be signed in to change notification settings - Fork 588
HDDS-11345. Add metrics specific tests for reconciliation tasks. #7732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-11345. Add metrics specific tests for reconciliation tasks. #7732
Conversation
errose28
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the test @aswinshakil. Can we move this so the tests for reconciliation tasks are in their own test method within TestReplicationSupervisor? We can throw one into the mix in testMultipleReplication since it is already there, but that method is already testing too many things at once and it is hard to follow the individual things being checked.
errose28
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this @aswinshakil
...er-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/ContainerLogger.java
Outdated
Show resolved
Hide resolved
...tainer-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java
Outdated
Show resolved
Hide resolved
...oop/ozone/container/common/statemachine/commandhandler/ReconcileContainerCommandHandler.java
Show resolved
Hide resolved
...ozone/container/common/statemachine/commandhandler/TestReconcileContainerCommandHandler.java
Outdated
Show resolved
Hide resolved
...ozone/container/common/statemachine/commandhandler/TestReconcileContainerCommandHandler.java
Show resolved
Hide resolved
...e/src/test/java/org/apache/hadoop/ozone/container/replication/TestReplicationSupervisor.java
Show resolved
Hide resolved
|
We need #7699 in our branch to fix acceptance tests |
5f43251 to
6fe3bdc
Compare
errose28
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @aswinshakil. Let's get the reverse merge from master in to fix our CI, then we can start merging our approved PRs to the branch.
|
@aswinshakil The reverse merge from master is done with green CI. Please merge this into your PR branch to retrigger CI with the new changes, which should fix the acceptance test issues. |
fa8e0a4
into
apache:HDDS-10239-container-reconciliation
What changes were proposed in this pull request?
#7140 Added a framework to add metrics for any
AbstractReplicationTask. This adds all the necessary metrics required for container reconciliation task(ReconcileContainerTask). This JIRA aims to add tests for these metrics.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11345
How was this patch tested?
Added unit tests.