Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

acceptance and some other checks fail intermittently (when run with Maven 3.9.9, example) due to:

  • Maven 3.9.x automatically picks up options from MAVEN_ARGS variable.
  • With --show-version, version is shown in the output, even with --quiet.
  • Property queries from POM (e.g. ozone.version) rely on only the value being output.
  • GitHub started gradual roll-out of runners with Maven 3.9.9.

This fix removes --show-version from global MAVEN_ARGS to avoid unwanted content in output of property queries.

https://issues.apache.org/jira/browse/HDDS-12082

How was this patch tested?

CI:
https://github.com/adoroszlai/ozone/actions/runs/12772268115

@adoroszlai adoroszlai added the CI label Jan 14, 2025
@adoroszlai adoroszlai self-assigned this Jan 14, 2025
Copy link
Contributor

@swamirishi swamirishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @adoroszlai LGTM

@adoroszlai adoroszlai merged commit 0723902 into apache:master Jan 14, 2025
44 checks passed
@adoroszlai adoroszlai deleted the HDDS-12082 branch January 14, 2025 20:54
@adoroszlai
Copy link
Contributor Author

Thanks @swamirishi for the review!

adoroszlai added a commit to adoroszlai/ozone that referenced this pull request Jan 28, 2025
adoroszlai added a commit to adoroszlai/ozone that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants