HDDS-11076. Revert HDDS-11076 and HDDS-11078 #7004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with Java 9+, running with Java 8 (apache#6897)" This reverts commit 8f610da.
This reverts commit 3f14219.
hemantk-12
approved these changes
Jul 29, 2024
Contributor
hemantk-12
left a comment
hemantk-12
left a comment
There was a problem hiding this comment.
Thanks for the prompt revert @adoroszlai
LGTM.
kerneltime
changed the title
Contributor
Author
|
Thanks @hemantk-12 for the review and reporting the problem, @kerneltime for merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Revert HDDS-11076 and HDDS-11078.
HDDS-11078 causes loss of signal handling functionality. In addition to Ozone-side fix, it also requires a fix in (and new release of)
jnr-posix, thus we must revert the change for now.HDDS-11076 requires HDDS-11078 (does not compile on Java 9+ with usage of
sun.misc.Signal), so we must revert these two together.How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/10148894587