Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

  1. Move SignalLogger to hdds-server-framework from hdds-common, as it is only used by servers, not clients.
  2. Replace usage of sun.misc.Signal and co. due to:
    sun.misc.Signal is internal proprietary API and may be removed in a future release
    
    It can be replaced with jnr-posix.

There are quite a few new (transitive) dependencies, but they are smallish jars and licenses are OK:

 120K asm-9.2.jar
  34K asm-analysis-9.2.jar
  71K asm-commons-9.2.jar
  52K asm-tree-9.2.jar
  83K asm-util-9.2.jar
 159K jffi-1.3.13.jar
 992K jffi-1.3.13-native.jar
  85K jnr-a64asm-1.0.0.jar
 1.6M jnr-constants-0.10.4.jar
 714K jnr-ffi-2.2.16.jar
 275K jnr-posix-3.1.19.jar
 215K jnr-x86asm-1.0.2.jar

https://issues.apache.org/jira/browse/HDDS-11078

How was this patch tested?

Tested with Docker Compose in ozone environment.

Signal handlers are registered:

ozone-om-1  | 2024-06-27 16:43:06,814 [main] INFO om.OzoneManagerStarter: registered UNIX signal handlers for [SIGHUP, SIGINT, SIGTERM]

Stopping container:

$ docker-compose stop om
Stopping ozone-om-1 ... done

sends signal as previously:

ozone-om-1  | 2024-06-27 16:43:46,007 [SIGTERM handler] ERROR om.OzoneManagerStarter: RECEIVED SIGNAL 15: SIGTERM
ozone-om-1 exited with code 137

CI:
https://github.com/adoroszlai/ozone/actions/runs/9701649212

@adoroszlai adoroszlai added the dependencies Pull requests that update a dependency file label Jun 27, 2024
@adoroszlai adoroszlai self-assigned this Jun 27, 2024
@adoroszlai adoroszlai requested review from ivandika3 and smengcl June 30, 2024 10:01
Copy link
Contributor

@ivandika3 ivandika3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adoroszlai Thanks for the patch. Did some research about it and LGTM +1.

@adoroszlai adoroszlai merged commit 3f14219 into apache:master Jul 4, 2024
@adoroszlai adoroszlai deleted the HDDS-11078 branch July 4, 2024 07:50
@adoroszlai
Copy link
Contributor Author

Thanks a lot @ivandika3 for the research and reviewing this.

adoroszlai added a commit to adoroszlai/ozone that referenced this pull request Jul 29, 2024
kerneltime pushed a commit that referenced this pull request Jul 29, 2024
* Revert "HDDS-11076. NoSuchMethodError: ByteBuffer.position compiling with Java 9+, running with Java 8 (#6897)"

This reverts commit 8f610da.

* Revert "HDDS-11078. Remove usage of sun.misc.Signal (#6876)"

This reverts commit 3f14219.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants