Skip to content

Conversation

@muskan1012
Copy link
Contributor

What changes were proposed in this pull request?

Created a new dashboard and added visualisations for all the required ReadKey Metrics.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-10112

How was this patch tested?

The patch has been tested over a Grafana.
image

Copy link
Contributor

@tanvipenumudy tanvipenumudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @muskan1012, for working on the patch.

Could you please share snapshots to the added dashboards over the PR?
Here are a few references: Dashboard for Chunks & Volume IO, S3 API-level Dashboard

@tanvipenumudy
Copy link
Contributor

@devabhishekpal could you also please take a look? Thanks!

@muskan1012
Copy link
Contributor Author

Sure @tanvipenumudy, please find snapshots here:
image
image
image

Copy link
Contributor

@devabhishekpal devabhishekpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.
Thanks @muskan1012 for the change.
+1

Copy link
Contributor

@tanvipenumudy tanvipenumudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as my previous comment on PR: #6865:

I have tested out the patch locally by setting up an Ozone docker-compose cluster with the monitoring add-ons, steps as outlined here.

I noticed that a few charts weren't coming up for me. It appears that there are 6 occurrences of hardcoded host values - could you please fix the same?

Additionally, once the updates are made, could you also please ensure the snapshots (as to how the patch was tested) include all the charts added for the read keys dashboard?

Copy link
Contributor

@tanvipenumudy tanvipenumudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find a few minor nits.

@muskan1012
Copy link
Contributor Author

@tanvipenumudy thanks for the review, I have addressed all of your comments and fixed minor nits as well.

Here I am attaching the Snapshot of the Dashboard with updated json.
image
image
image

@muskan1012
Copy link
Contributor Author

Thank you @devabhishekpal for reviewing it.

@tanvipenumudy tanvipenumudy changed the title HDDS-10112. Dashboard for ReadKeys HDDS-10112. Dashboard for read key metrics Jul 9, 2024
Copy link
Contributor

@tanvipenumudy tanvipenumudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @muskan1012 for working on the patch, the changes LGTM. Thank you @devabhishekpal for reviewing.

@tanvipenumudy tanvipenumudy merged commit 44df637 into apache:master Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants