-
Notifications
You must be signed in to change notification settings - Fork 588
HDDS-10112. Dashboard for read key metrics #6868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tanvipenumudy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @muskan1012, for working on the patch.
Could you please share snapshots to the added dashboards over the PR?
Here are a few references: Dashboard for Chunks & Volume IO, S3 API-level Dashboard
|
@devabhishekpal could you also please take a look? Thanks! |
|
Sure @tanvipenumudy, please find snapshots here: |
devabhishekpal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Thanks @muskan1012 for the change.
+1
tanvipenumudy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as my previous comment on PR: #6865:
I have tested out the patch locally by setting up an Ozone docker-compose cluster with the monitoring add-ons, steps as outlined here.
I noticed that a few charts weren't coming up for me. It appears that there are 6 occurrences of hardcoded host values - could you please fix the same?
Additionally, once the updates are made, could you also please ensure the snapshots (as to how the patch was tested) include all the charts added for the read keys dashboard?
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - ReadKey Metrics.json
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - ReadKey Metrics.json
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - ReadKey Metrics.json
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - ReadKey Metrics.json
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - ReadKey Metrics.json
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - ReadKey Metrics.json
Outdated
Show resolved
Hide resolved
tanvipenumudy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please find a few minor nits.
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - ReadKey Metrics.json
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - ReadKey Metrics.json
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - ReadKey Metrics.json
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - ReadKey Metrics.json
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - ReadKey Metrics.json
Outdated
Show resolved
Hide resolved
hadoop-ozone/dist/src/main/compose/common/grafana/dashboards/Ozone - ReadKey Metrics.json
Outdated
Show resolved
Hide resolved
|
@tanvipenumudy thanks for the review, I have addressed all of your comments and fixed minor nits as well. Here I am attaching the Snapshot of the Dashboard with updated json. |
|
Thank you @devabhishekpal for reviewing it. |
tanvipenumudy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @muskan1012 for working on the patch, the changes LGTM. Thank you @devabhishekpal for reviewing.






What changes were proposed in this pull request?
Created a new dashboard and added visualisations for all the required ReadKey Metrics.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10112
How was this patch tested?
The patch has been tested over a Grafana.
