Skip to content

Conversation

@muskan1012
Copy link
Contributor

@muskan1012 muskan1012 commented Jun 25, 2024

What changes were proposed in this pull request?

Created a new dashboard and added visualisations for all the required CreateKey Metrics.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-9977

How was this patch tested?

The patch has been tested over a Grafana.
image

@muskan1012 muskan1012 changed the title createKey dashboard added HDDS-9977. Dashboard for create keys Jun 25, 2024
@muskan1012 muskan1012 changed the title HDDS-9977. Dashboard for create keys HDDS-9977. Dashboard for create keys. Jun 25, 2024
Copy link
Contributor

@tanvipenumudy tanvipenumudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @muskan1012, for working on the patch.

Could you please share snapshots to the added dashboards over the PR?
Here are a few references: Dashboard for Chunks & Volume IO, S3 API-level Dashboard

@tanvipenumudy
Copy link
Contributor

@devabhishekpal could you also please take a look? Thanks!

@muskan1012
Copy link
Contributor Author

Sure @tanvipenumudy, please find snapshot for the dashboards here:
image
image

Copy link
Contributor

@tanvipenumudy tanvipenumudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested out the patch locally by setting up an Ozone docker-compose cluster with the monitoring add-ons, steps as outlined here.

I noticed that a few charts weren't coming up for me. It appears there are 31 occurrences of hardcoded host values. Could you please fix the same?

Additionally, once the updates are made, could you also please ensure the snapshots (as to how the patch was tested) include all the charts added for the create keys dashboard?

Copy link
Contributor

@tanvipenumudy tanvipenumudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find a few minor nits.

@tanvipenumudy tanvipenumudy changed the title HDDS-9977. Dashboard for create keys. HDDS-9977. Dashboard for create key metrics Jul 8, 2024
@tanvipenumudy
Copy link
Contributor

Thank you @muskan1012 for working on the create keys dashboard, the changes LGTM.

This should be very helpful in diagnosing performance-related issues/regressions.

@tanvipenumudy tanvipenumudy merged commit d6d33f6 into apache:master Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants