Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Backport the following fixes from master to ozone-1.4 for 1.4.1.

If approved, I'll push to the ozone-1.4 branch directly.

How was this patch tested?

CI:
https://github.com/adoroszlai/ozone/actions/runs/8000506651

adoroszlai and others added 13 commits February 21, 2024 15:51
@adoroszlai adoroszlai self-assigned this Feb 22, 2024
@adoroszlai
Copy link
Contributor Author

/pending DO NOT MERGE

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this issue as un-mergeable as requested.

Please use /ready comment when it's resolved.

Please note that the PR will be closed after 21 days of inactivity from now. (But can be re-opened anytime later...)

DO NOT MERGE

@ivandika3
Copy link
Contributor

@adoroszlai thank you for the backport fixes.

In the previous backport #6096, @hemantk-12 suggested to include two fixes:

Shall we include them in this backport patch?

@adoroszlai
Copy link
Contributor Author

Thanks @ivandika3 for the reminder.

@adoroszlai
Copy link
Contributor Author

@myskov please review 1a235b6

@hemantk-12 please review 9954d41 and b6a1226

Copy link
Contributor

@myskov myskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ferhui
Copy link
Contributor

ferhui commented Feb 23, 2024

Thanks for backporting it. Do we have a release plan for 1.4.1?

@adoroszlai
Copy link
Contributor Author

@hemantk-12 this backport includes two snapshot-related patches (9954d41 and b6a1226), would you like to take a look?

Copy link
Contributor

@hemantk-12 hemantk-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adoroszlai for the back porting this fixes. And sorry for the delayed review somehow I missed it earlier.

LGTM.

@adoroszlai adoroszlai merged commit b6a1226 into apache:ozone-1.4 Feb 25, 2024
@adoroszlai
Copy link
Contributor Author

Thanks @hemantk-12, @myskov for the review.

sorry for the delayed review somehow I missed it earlier.

No problem, I just wanted to merge this during the weekend because CI is less busy then.

Do we have a release plan for 1.4.1?

@ferhui no plan yet, we can discuss this on dev@ mailing list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants