-
Notifications
You must be signed in to change notification settings - Fork 588
[DO NOT MERGE] Backport some fixes from master to ozone-1.4
#6252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Backport some fixes from master to ozone-1.4
#6252
Conversation
…hrows (apache#6097) (cherry picked from commit dd54a7a)
(cherry picked from commit 86bbdfc)
(cherry picked from commit 80ffcc0)
…1.0 (apache#5996) (cherry picked from commit 02bfa7f)
(cherry picked from commit 652b9bc)
(cherry picked from commit cc9089d)
(cherry picked from commit 3a01fea)
…ation (apache#6088) (cherry picked from commit 73f0194)
…ordinator (apache#6163) (cherry picked from commit 5dd14ac)
…ache#5887) (cherry picked from commit 27c1f9c)
…ersion (apache#6089) (cherry picked from commit 9238be3)
(cherry picked from commit 06386a7)
(cherry picked from commit 2e89fcf)
|
/pending DO NOT MERGE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking this issue as un-mergeable as requested.
Please use /ready comment when it's resolved.
Please note that the PR will be closed after 21 days of inactivity from now. (But can be re-opened anytime later...)
DO NOT MERGE
|
@adoroszlai thank you for the backport fixes. In the previous backport #6096, @hemantk-12 suggested to include two fixes: Shall we include them in this backport patch? |
…apache#5986) (cherry picked from commit a8341d7)
…shotBackgroundServices (apache#6026) (cherry picked from commit 2c0580d)
|
Thanks @ivandika3 for the reminder. |
|
@hemantk-12 please review 9954d41 and b6a1226 |
myskov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks for backporting it. Do we have a release plan for 1.4.1? |
|
@hemantk-12 this backport includes two snapshot-related patches (9954d41 and b6a1226), would you like to take a look? |
hemantk-12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adoroszlai for the back porting this fixes. And sorry for the delayed review somehow I missed it earlier.
LGTM.
|
Thanks @hemantk-12, @myskov for the review.
No problem, I just wanted to merge this during the weekend because CI is less busy then.
@ferhui no plan yet, we can discuss this on dev@ mailing list. |
What changes were proposed in this pull request?
Backport the following fixes from
mastertoozone-1.4for 1.4.1.S3SecretValueproto conversion (HDDS-10200. OM may terminate due to NPE inS3SecretValueproto conversion #6089)If approved, I'll push to the
ozone-1.4branch directly.How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/8000506651