HDDS-10294. Actual client configuration ignored in ECReconstructionCoordinator #6163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodonnel
approved these changes
Feb 5, 2024
Contributor
Author
|
Thanks @sodonnel for the review. |
adoroszlai
added a commit
to adoroszlai/ozone
that referenced
this pull request
Feb 21, 2024
…ordinator (apache#6163) (cherry picked from commit 5dd14ac)
adoroszlai
added a commit
to adoroszlai/ozone
that referenced
this pull request
Feb 21, 2024
…ordinator (apache#6163) (cherry picked from commit 5dd14ac)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Create and store
OzoneClientConfiginstance viaConfigurationSource#getObjectto ensure actual config values (coming fromozone-site.xml) are injected into the object. Creatingnew OzoneClientConfig()initializes it with the default values, defined in the class.(There are similar bugs in some integration tests. Those will be fixed as part of HDDS-10292, to make it easier to backport the fix for prod code.)
https://issues.apache.org/jira/browse/HDDS-10294
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7778426128