-
Notifications
You must be signed in to change notification settings - Fork 588
HDDS-2850. Handle Create container use case in Recon. #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
103 changes: 103 additions & 0 deletions
103
...c/main/java/org/apache/hadoop/ozone/recon/scm/ReconIncrementalContainerReportHandler.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * <p> | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * <p> | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.ozone.recon.scm; | ||
|
|
||
| import java.io.IOException; | ||
|
|
||
| import org.apache.hadoop.hdds.protocol.DatanodeDetails; | ||
| import org.apache.hadoop.hdds.protocol.proto.StorageContainerDatanodeProtocolProtos.ContainerReplicaProto; | ||
| import org.apache.hadoop.hdds.scm.container.ContainerID; | ||
| import org.apache.hadoop.hdds.scm.container.ContainerManager; | ||
| import org.apache.hadoop.hdds.scm.container.ContainerNotFoundException; | ||
| import org.apache.hadoop.hdds.scm.container.IncrementalContainerReportHandler; | ||
| import org.apache.hadoop.hdds.scm.container.common.helpers.ContainerWithPipeline; | ||
| import org.apache.hadoop.hdds.scm.node.NodeManager; | ||
| import org.apache.hadoop.hdds.scm.node.states.NodeNotFoundException; | ||
| import org.apache.hadoop.hdds.scm.server.SCMDatanodeHeartbeatDispatcher.IncrementalContainerReportFromDatanode; | ||
| import org.apache.hadoop.hdds.server.events.EventPublisher; | ||
| import org.apache.hadoop.ozone.recon.spi.StorageContainerServiceProvider; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| /** | ||
| * Recon ICR handler. | ||
| */ | ||
| public class ReconIncrementalContainerReportHandler | ||
| extends IncrementalContainerReportHandler { | ||
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger( | ||
| ReconIncrementalContainerReportHandler.class); | ||
|
|
||
| private StorageContainerServiceProvider scmClient; | ||
|
|
||
| public ReconIncrementalContainerReportHandler(NodeManager nodeManager, | ||
| ContainerManager containerManager, | ||
| StorageContainerServiceProvider scmClient) { | ||
| super(nodeManager, containerManager); | ||
| this.scmClient = scmClient; | ||
| } | ||
|
|
||
| @Override | ||
| public void onMessage(final IncrementalContainerReportFromDatanode report, | ||
| final EventPublisher publisher) { | ||
| if (LOG.isDebugEnabled()) { | ||
| LOG.debug("Processing incremental container report from data node {}", | ||
| report.getDatanodeDetails()); | ||
| } | ||
|
|
||
| ReconContainerManager containerManager = | ||
| (ReconContainerManager) getContainerManager(); | ||
| boolean success = true; | ||
| for (ContainerReplicaProto replicaProto : | ||
| report.getReport().getReportList()) { | ||
| try { | ||
| final DatanodeDetails dd = report.getDatanodeDetails(); | ||
| final ContainerID id = ContainerID.valueof( | ||
| replicaProto.getContainerID()); | ||
| if (!getContainerManager().exists(id)) { | ||
| LOG.info("New container {} got from {}.", id, | ||
| report.getDatanodeDetails()); | ||
| try { | ||
| ContainerWithPipeline containerWithPipeline = | ||
| scmClient.getContainerWithPipeline(id.getId()); | ||
| containerManager.addNewContainer(id.getId(), containerWithPipeline); | ||
| } catch (IOException ioEx) { | ||
| LOG.error("Exception while getting new container info from SCM", | ||
| ioEx); | ||
| return; | ||
| } | ||
| } | ||
| getNodeManager().addContainer(dd, id); | ||
| processContainerReplica(dd, replicaProto); | ||
| } catch (ContainerNotFoundException e) { | ||
| success = false; | ||
| LOG.warn("Container {} not found!", replicaProto.getContainerID()); | ||
| } catch (NodeNotFoundException ex) { | ||
| success = false; | ||
| LOG.error("Received ICR from unknown datanode {} {}", | ||
| report.getDatanodeDetails(), ex); | ||
| } catch (IOException e) { | ||
| success = false; | ||
| LOG.error("Exception while processing ICR for container {}", | ||
| replicaProto.getContainerID()); | ||
| } | ||
| } | ||
| getContainerManager().notifyContainerReportProcessing(false, success); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 changes: 84 additions & 0 deletions
84
...on/src/test/java/org/apache/hadoop/ozone/recon/scm/AbstractReconContainerManagerTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * <p> | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * <p> | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.ozone.recon.scm; | ||
|
|
||
| import static org.apache.hadoop.hdds.scm.ScmConfigKeys.OZONE_SCM_NAMES; | ||
| import static org.apache.hadoop.ozone.OzoneConfigKeys.OZONE_METADATA_DIRS; | ||
|
|
||
| import java.io.IOException; | ||
|
|
||
| import org.apache.hadoop.hdds.conf.OzoneConfiguration; | ||
| import org.apache.hadoop.hdds.scm.net.NetworkTopology; | ||
| import org.apache.hadoop.hdds.scm.net.NetworkTopologyImpl; | ||
| import org.apache.hadoop.hdds.scm.node.NodeManager; | ||
| import org.apache.hadoop.hdds.scm.node.SCMNodeManager; | ||
| import org.apache.hadoop.hdds.scm.server.SCMStorageConfig; | ||
| import org.apache.hadoop.hdds.server.events.EventQueue; | ||
| import org.junit.After; | ||
| import org.junit.Before; | ||
| import org.junit.Rule; | ||
| import org.junit.rules.TemporaryFolder; | ||
|
|
||
| /** | ||
| * Abstract class for Recon Container Manager related tests. | ||
| */ | ||
| public class AbstractReconContainerManagerTest { | ||
|
|
||
| @Rule | ||
| public TemporaryFolder temporaryFolder = new TemporaryFolder(); | ||
|
|
||
| private OzoneConfiguration conf; | ||
| private SCMStorageConfig scmStorageConfig; | ||
| private ReconPipelineManager pipelineManager; | ||
| private ReconContainerManager containerManager; | ||
|
|
||
| @Before | ||
| public void setUp() throws Exception { | ||
| conf = new OzoneConfiguration(); | ||
| conf.set(OZONE_METADATA_DIRS, | ||
| temporaryFolder.newFolder().getAbsolutePath()); | ||
| conf.set(OZONE_SCM_NAMES, "localhost"); | ||
| scmStorageConfig = new ReconStorageConfig(conf); | ||
| NetworkTopology clusterMap = new NetworkTopologyImpl(conf); | ||
| EventQueue eventQueue = new EventQueue(); | ||
| NodeManager nodeManager = | ||
| new SCMNodeManager(conf, scmStorageConfig, eventQueue, clusterMap); | ||
| pipelineManager = new ReconPipelineManager(conf, nodeManager, eventQueue); | ||
| containerManager = new ReconContainerManager(conf, pipelineManager); | ||
| } | ||
|
|
||
| @After | ||
| public void tearDown() throws IOException { | ||
| containerManager.close(); | ||
| pipelineManager.close(); | ||
| } | ||
|
|
||
| protected OzoneConfiguration getConf() { | ||
| return conf; | ||
| } | ||
|
|
||
| protected ReconPipelineManager getPipelineManager() { | ||
| return pipelineManager; | ||
| } | ||
|
|
||
| protected ReconContainerManager getContainerManager() { | ||
| return containerManager; | ||
| } | ||
|
|
||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.