HDDS-2850. Handle Create container use case in Recon. #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swagle
reviewed
Jan 30, 2020
...-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/SCMContainerManager.java
Show resolved
Hide resolved
swagle
reviewed
Jan 30, 2020
.../src/main/java/org/apache/hadoop/ozone/recon/scm/ReconIncrementalContainerReportHandler.java
Outdated
Show resolved
Hide resolved
adoroszlai
approved these changes
Jan 30, 2020
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks for working on this @avijayanhwx. LGTM. Can you please consider some suggested code simplification?
.../src/main/java/org/apache/hadoop/ozone/recon/scm/ReconIncrementalContainerReportHandler.java
Outdated
Show resolved
Hide resolved
...p-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/scm/TestReconContainerManager.java
Outdated
Show resolved
Hide resolved
...p-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/scm/TestReconContainerManager.java
Outdated
Show resolved
Hide resolved
.../test/java/org/apache/hadoop/ozone/recon/scm/TestReconIncrementalContainerReportHandler.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@adoroszlai Thanks for the review. Addressed your review comments. |
Contributor
|
Thanks @avijayanhwx for updating the patch. @nandakumar131 would you like to review this or can I merge it? |
Contributor
|
@adoroszlai Thanks for the review. I will take a look at the changes and merge it. |
nandakumar131
approved these changes
Feb 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
CREATE container needs to be handled differently in Recon since it is initiated in the SCM, and Recon does not know about that. It should not throw a ContainerNotFoundException when it suddenly sees a new container.
Whenever a new container is created on the Datanode, it sends an incremental container report. This is picked up by Recon, treated as a new container and then Recon queries SCM about the new container.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2850
How was this patch tested?
Manually tested.
Unit tested.