HDDS-8572. Support CodecBuffer for protobuf v3 codecs. #4693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
May 14, 2023
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @szetszwo for the patch, LGTM, just one question.
Comment on lines
+36
to
+46
| private static final ConcurrentMap<Class<? extends MessageLite>, | ||
| Codec<? extends MessageLite>> CODECS | ||
| = new ConcurrentHashMap<>(); | ||
|
|
||
| /** | ||
| * @return the {@link Codec} for the given class. | ||
| */ | ||
| public static <T extends MessageLite> Codec<T> get(Class<T> clazz) { | ||
| final Codec<?> codec = CODECS.computeIfAbsent(clazz, Proto3Codec::new); | ||
| return (Codec<T>) codec; | ||
| } |
Contributor
There was a problem hiding this comment.
What is the benefit of saving codec instances to the map? Are we likely to have multiple uses of the same proto message in different domain objects?
Contributor
Author
There was a problem hiding this comment.
The map is to enforce singleton. We may consider Proto3Codec::new expensive since it uses reflection to create an object. Suppose we return a new object as below
public static <T extends MessageLite> Codec<T> getNew(Class<T> clazz) {
return new Proto3Codec(clazz);
}Then, it can possibly be misused as
getNew().toCodecBuffer(message, allocator);i.e. it creates a new codec for each serialization.
Contributor
Author
|
@adoroszlai , thanks a lot for reviewing this! |
Contributor
Author
|
@adoroszlai , oops, just found you have not approved this. Sorry! We may revert the commit if you have further questions or comments. |
errose28
added a commit
to errose28/ozone
that referenced
this pull request
May 17, 2023
* master: (78 commits) HDDS-8575. Intermittent failure in TestCloseContainerEventHandler.testCloseContainerWithDelayByLeaseManager (apache#4688) HDDS-7241. EC: Reconstruction could fail with orphan blocks. (apache#4718) HDDS-8577. [Snapshot] Disable compaction log when loading metadata for snapshot (apache#4697) HDDS-7080. EC: Offline reconstruction needs better logging (apache#4719) HDDS-8626. Config thread pool in ReplicationServer (apache#4715) HDDS-8616. Underreplication not fixed if all replicas start decommissioning (apache#4711) HDDS-8254. Close containers when volume reaches utilisation threshold (apache#4583) HDDS-8254. Close containers when volume reaches utilisation threshold (apache#4583) HDDS-8615. Explicitly show EC block type in 'ozone debug chunkinfo' command output (apache#4706) HDDS-8623. Delete duplicate getBucketInfo in OMKeyCommitRequest (apache#4712) HDDS-8339. Recon Show the number of keys marked for Deletion in Recon UI. (apache#4519) HDDS-8572. Support CodecBuffer for protobuf v3 codecs. (apache#4693) HDDS-8010. Improve DN warning message when getBlock does not find the block. (apache#4698) HDDS-8621. IOException is never thrown in SCMRatisServer.getRatisRoles(). (apache#4710) HDDS-8463. S3 key uniqueness in deletedTable (apache#4660) HDDS-8584. Hadoop client write slowly when stream enabled (apache#4703) HDDS-7732. EC: Verify block deletion from missing EC containers (apache#4705) HDDS-8581. Avoid random ports in integration tests (apache#4699) HDDS-8504. ReplicationManager: Pass used and excluded node separately for Under and Mis-Replication (apache#4694) HDDS-8576. Close RocksDB instance in RDBStore if RDBStore's initialization fails after RocksDB instance creation (apache#4692) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Provide a general mechanism to support CodecBuffer for the codecs with protobuf v3 data.
What is the link to the Apache JIRA
HDDS-8572
How was this patch tested?
By existing tests.