HDDS-7789. [Snapshot] Provide API for snapDiff from OFS. #4491
Conversation
sadanand48
changed the title
...onefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneClientAdapterImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@sadanand48 - if deleting this temp snapshot throws exception, is there a possibility of building such temp snapshots in disk ?
There was a problem hiding this comment.
Yes thats a good point, there is a snapshot deleting task that cares care of cleaning up the deleted snapshots, we could add handling there to delete these type of snapshots if present. I will create a separate jira for this.
cc @smengcl
There was a problem hiding this comment.
Temp snapshots should not be part of Garbage collection on their own. We need to have a separate service to issue deletes on the temporary snapshots. This can be a separate Jira and a separte PR.
I have filed https://issues.apache.org/jira/browse/HDDS-8483 to track this.
...onefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneClientAdapterImpl.java
Outdated
Show resolved
Hide resolved
prashantpogde
left a comment
prashantpogde
left a comment
There was a problem hiding this comment.
Looks good to me, thanks Sadanand
4 participants
What changes were proposed in this pull request?
Provide API for snapDiff from OFS.
The main change here is to reuse
org.apache.hadoop.hdfs.protocol.SnapshotDiffReporti.eorg.apache.hadoop.ozone.snapshot.SnapshotDiffReportwill extendorg.apache.hadoop.hdfs.protocol.SnapshotDiffReport.Distcp makes use of getFS().getSnapshotDiffReport() which expects this return type. Using this also reduces some code duplication.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7789
How was this patch tested?
Unit tests