HDDS-7916. [Snapshot] Support for Distcp with Ozone Snapshots. #4252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadanand48
changed the title
Contributor
|
@sadanand48 Can you please resolve the conflicts ? |
| @Override | ||
| public void readUnlock(String opName) { | ||
| // not used anywhere, implemented as part of interface. | ||
| this.lock.writeLock().lock(); |
prashantpogde
approved these changes
Feb 27, 2023
Contributor
prashantpogde
left a comment
prashantpogde
left a comment
There was a problem hiding this comment.
Other changes look good to me.
sadanand48
force-pushed
the
HDDS-7916
branch
from
7335802 to
4a21a3b
Compare
Contributor
|
Thanks @sadanand48 . Can we rebase this and mark this as ready for review? |
Contributor
Author
|
Broke down this patch into a change which doesn't depend on hdfs version upgrade and created #4491 |
Contributor
Thanks @sadanand48 . Shall we close this PR then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Main changes
org.apache.hadoop.ozone.snapshot.SnapshotDiffReportextendorg.apache.hadoop.hdfs.protocol.SnapshotDiffReportChanges to pom.xml
hadoop-distcpdependency toozonefs-commonhadoop-hdfs-clienttoozone-common(required to accessorg.apache.hadoop.hdfs.protocol.SnapshotDiffReport)hadoopversion to3.4.0-Snapshotthat contains changes for distcp to work with ozone with snapshots.kerby.versionas it was throwing Dependency convergence error for org.apache.kerby:kerb-core:jar:1.0.1 since latest version of hadoop uses this version.this change requires latest version of hadoop that contains HDFS-16911.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7916
How was this patch tested?
Unit tests