Skip to content

HDDS-6979. Remove unused plexus dependency declaration #3579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JacksonYao287 merged 1 commit into from
Jul 3, 2022
Merged

HDDS-6979. Remove unused plexus dependency declaration #3579

JacksonYao287 merged 1 commit into from
Jul 3, 2022

Conversation

@adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented Jul 2, 2022

What changes were proposed in this pull request?

Dependencies from org.codehaus.plexus are defined in dependencyManagement, but never actually used, so can be removed.

https://issues.apache.org/jira/browse/HDDS-6979

How was this patch tested?

Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/2600537869

@adoroszlai adoroszlai self-assigned this Jul 2, 2022
@adoroszlai adoroszlai added the dependencies Pull requests that update a dependency file label Jul 2, 2022
ayushtkn
ayushtkn reviewed Jul 2, 2022
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to remove If it is unused.
BTW any pointers why it was kept here in the first place? and if it is packaged today or not? Just curious if it was there for some runtime purpose or so, or was it just a miss.

@adoroszlai
Copy link
Contributor Author

adoroszlai commented Jul 2, 2022

Thanks @ayushtkn for taking a look.

BTW any pointers why it was kept here in the first place? and if it is packaged today or not? Just curious if it was there for some runtime purpose or so, or was it just a miss.

HDDS-2106 copied lots of definitions from Hadoop POM to pom.ozone.xml (which was renamed to root pom.xml after the repo split), to be able to use it as a parent for subprojects instead of hadoop-project.

plexus-utils and plexus-component-annotations are not included in the binary tarball, since they are neither explicitly used as dependencies, nor are they transitive ones. They are used by hadoop-maven-plugins, which does not have an Ozone equivalent.

ayushtkn
ayushtkn approved these changes Jul 2, 2022
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JacksonYao287
JacksonYao287 approved these changes Jul 3, 2022
View reviewed changes
Copy link
Contributor

@JacksonYao287 JacksonYao287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @adoroszlai for the work and @ayushtkn for the review! i have commit the patch to master branch

@JacksonYao287 JacksonYao287 merged commit 3873753 into apache:master Jul 3, 2022
@adoroszlai adoroszlai deleted the HDDS-6979 branch July 3, 2022 12:41
@adoroszlai
Copy link
Contributor Author

adoroszlai commented Jul 3, 2022

Thanks @ayushtkn for the review, @JacksonYao287 for reviewing and merging this.

errose28 added a commit to errose28/ozone that referenced this pull request Jul 12, 2022
@errose28
Merge branch 'master' into HDDS-6761-take2
c9b9a9d 
* master: (46 commits)
  HDDS-6901. Configure HDDS volume reserved as percentage of the volume space. (apache#3532)
  HDDS-6978. EC: Cleanup RECOVERING container on DN restarts (apache#3585)
  HDDS-6982. EC: Attempt to cleanup the RECOVERING container when reconstruction failed at coordinator. (apache#3583)
  HDDS-6968. Addendum: [Multi-Tenant] Fix USER_MISMATCH error even on correct user. (apache#3578)
  HDDS-6794. EC: Analyze and add putBlock even on non writing node in the case of partial single stripe. (apache#3514)
  HDDS-6900. Propagate TimeoutException for all SCM HA Ratis calls. (apache#3564)
  HDDS-6938. handle NPE when removing prefixAcl (apache#3568)
  HDDS-6960. EC: Implement the Over-replication Handler (apache#3572)
  HDDS-6979. Remove unused plexus dependency declaration (apache#3579)
  HDDS-6957. EC: ReplicationManager - priortise under replicated containers (apache#3574)
  HDDS-6723. Close Rocks objects properly in OzoneManager (apache#3400)
  HDDS-6942. Ozone Buckets/Objects created via S3 should not allow group access (apache#3553)
  HDDS-6965. Increase timeout for basic check (apache#3563)
  HDDS-6969. Add link to compose directory in smoketest README (apache#3567)
  HDDS-6970. EC: Ensure DatanodeAdminMonitor can handle EC containers during decommission (apache#3573)
  HDDS-6977. EC: Remove references to ContainerReplicaPendingOps in TestECContainerReplicaCount (apache#3575)
  HDDS-6217. Cleanup XceiverClientGrpc TODOs, and document how the client works and should be used. (apache#3012)
  HDDS-6773. Cleanup TestRDBTableStore (apache#3434) - fix checkstyle
  HDDS-6773. Cleanup TestRDBTableStore (apache#3434)
  HDDS-6676. KeyValueContainerData#getProtoBufMessage() should set block count (apache#3371)
  ...

Conflicts:
    hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/upgrade/SCMUpgradeFinalizer.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ayushtkn ayushtkn ayushtkn approved these changes

@JacksonYao287 JacksonYao287 JacksonYao287 approved these changes

Assignees

@adoroszlai adoroszlai

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adoroszlai @ayushtkn @JacksonYao287