Skip to content

Conversation

@kaijchen
Copy link
Member

What changes were proposed in this pull request?

The current README in smoketest reference compose directory like a sub-directory.
It was quite confusing at first glance.

This patch adds link to compose directory, and changes the path in the command example.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-6969

How was this patch tested?

Rendered version: https://github.com/kaijchen/ozone/blob/HDDS-6969/hadoop-ozone/dist/src/main/smoketest/README.md

@kaijchen
Copy link
Member Author

Cc @adoroszlai PTAL.

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kaijchen for working on this.

The first code block changes to the parent directory of smoketest, not into smoketest itself:

cd $DIRECTORY_OF_OZONE
robot smoketest/basic

So I think subsequent code blocks are correct.

# Run tests in docker environment

In the ./compose folder there are additional test scripts to make it easy to run all tests or run a specific test in a docker environment.
In the [compose](../compose) folder there are additional test scripts to make it easy to run all tests or run a specific test in a docker environment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is fine.

@kaijchen
Copy link
Member Author

kaijchen commented Jul 1, 2022

The first code block changes to the parent directory of smoketest, not into smoketest itself:

Oops, I didn't notice that. Thanks for the review @adoroszlai.

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kaijchen for updating the patch.

@adoroszlai adoroszlai merged commit 30f45b0 into apache:master Jul 1, 2022
errose28 added a commit to errose28/ozone that referenced this pull request Jul 12, 2022
* master: (46 commits)
  HDDS-6901. Configure HDDS volume reserved as percentage of the volume space. (apache#3532)
  HDDS-6978. EC: Cleanup RECOVERING container on DN restarts (apache#3585)
  HDDS-6982. EC: Attempt to cleanup the RECOVERING container when reconstruction failed at coordinator. (apache#3583)
  HDDS-6968. Addendum: [Multi-Tenant] Fix USER_MISMATCH error even on correct user. (apache#3578)
  HDDS-6794. EC: Analyze and add putBlock even on non writing node in the case of partial single stripe. (apache#3514)
  HDDS-6900. Propagate TimeoutException for all SCM HA Ratis calls. (apache#3564)
  HDDS-6938. handle NPE when removing prefixAcl (apache#3568)
  HDDS-6960. EC: Implement the Over-replication Handler (apache#3572)
  HDDS-6979. Remove unused plexus dependency declaration (apache#3579)
  HDDS-6957. EC: ReplicationManager - priortise under replicated containers (apache#3574)
  HDDS-6723. Close Rocks objects properly in OzoneManager (apache#3400)
  HDDS-6942. Ozone Buckets/Objects created via S3 should not allow group access (apache#3553)
  HDDS-6965. Increase timeout for basic check (apache#3563)
  HDDS-6969. Add link to compose directory in smoketest README (apache#3567)
  HDDS-6970. EC: Ensure DatanodeAdminMonitor can handle EC containers during decommission (apache#3573)
  HDDS-6977. EC: Remove references to ContainerReplicaPendingOps in TestECContainerReplicaCount (apache#3575)
  HDDS-6217. Cleanup XceiverClientGrpc TODOs, and document how the client works and should be used. (apache#3012)
  HDDS-6773. Cleanup TestRDBTableStore (apache#3434) - fix checkstyle
  HDDS-6773. Cleanup TestRDBTableStore (apache#3434)
  HDDS-6676. KeyValueContainerData#getProtoBufMessage() should set block count (apache#3371)
  ...

Conflicts:
    hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/upgrade/SCMUpgradeFinalizer.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants