HDDS-6899. [EC] Remove warnings and errors from console during online reconstruction of data. #3522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JyotinderSingh
changed the title
Contributor
|
Hi @swamirishi, the title of the pull request should be the same as that of the Jira ticket. I have modified it to fit the requirement. |
JyotinderSingh
changed the title
Contributor
|
I have just re triggered the CI. Did you get chance to check how these messages appearing in this he console with these changes? |
Contributor
There was a problem hiding this comment.
How about "if isDebugEnabled, we can log debug one, otherwise error?"
in that case, debug logging also should have some details.
Contributor
|
@swamirishi you may want to run the checkstyle locally first to know if any checkstyle warnings. |
| String message = "Failed to execute command {}."; | ||
| if (LOG.isDebugEnabled()) { | ||
| LOG.debug(message, processForDebug(request), e); | ||
| } else { |
Contributor
There was a problem hiding this comment.
Nit: You need to give space before "Exception Class".
| " to an error in ECBlockReader."; | ||
| if(LOG.isDebugEnabled()) { | ||
| LOG.debug(message, e); | ||
| } else { |
Contributor
There was a problem hiding this comment.
Nit: Give space after {}
Contributor
There was a problem hiding this comment.
Ok, I see, please ignore this one. comma is out side of string. Thanks
Contributor
|
Please run the local checkstyle before posting the PR. |
Contributor
|
Congratulations @swamirishi for your first commit :-) |
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Jun 23, 2022
* master: (34 commits) HDDS-6868 Add S3Auth information to thread local (apache#3527) HDDS-6877. Keep replication port unchanged when restarting datanode in MiniOzoneCluster (apache#3510) HDDS-6907. OFS should create buckets with FILE_SYSTEM_OPTIMIZED layout. (apache#3528) HDDS-6875. Migrate parameterized tests in hdds-common to JUnit5 (apache#3513) HDDS-6924. OBJECT_STORE isn't flat namespaced (apache#3533) HDDS-6899. [EC] Remove warnings and errors from console during online reconstruction of data. (apache#3522) HDDS-6695. Enable SCM Ratis by default for new clusters only (apache#3499) HDDS-4123. Integrate OM Open Key Cleanup Service Into Existing Code (apache#3319) HDDS-6882. Correct exit code for invalid arguments passed to command-line tools. (apache#3517) HDDS-6890. EC: Fix potential wrong replica read with over-replicated container. (apache#3523) HDDS-6902. Duplicate mockito-core entries in pom.xml (apache#3525) HDDS-6752. Migrate tests with rules in hdds-server-scm to JUnit5 (apache#3442) HDDS-6806. EC: Implement the EC Reconstruction coordinator. (apache#3504) HDDS-6829. Limit the no of inflight replication tasks in SCM. (apache#3482) HDDS-6898. [SCM HA finalization] Modify acceptance test configuration to speed up test finalization (apache#3521) HDDS-6577. Configurations to reserve HDDS volume space. (apache#3484) HDDS-6870 Clean up isTenantAdmin to use UGI (apache#3503) HDDS-6872. TestAuthorizationV4QueryParser should pass offline (apache#3506) HDDS-6840. Add MetaData volume information to the SCM and OM - UI (apache#3488) HDDS-6697. EC: ReplicationManager - create class to detect EC container health issues (apache#3512) ...
duongkame
pushed a commit
to duongkame/ozone
that referenced
this pull request
Aug 16, 2022
…uring online reconstruction of data. (apache#3522) (cherry picked from commit bf71b54) Change-Id: Id5fe0ee371985d166a1a1147dab01aad659023a3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Exception stacktrace put in debug level instead of warn or error level.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6899
How was this patch tested?
Logging Changes, no change in logic.