HDDS-6697. EC: ReplicationManager - create class to detect EC container health issues #3512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 13, 2022 12:52
…e decommissioning indexes from the list
...m/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ECContainerHealthCheck.java
Show resolved
Hide resolved
| * will the container still be over-replicated when they complete. | ||
| * @return True if the over-replication is corrected by the pending | ||
| * deletes. False otherwise. | ||
| */ |
Contributor
There was a problem hiding this comment.
For consistency, you may want to rename this to isSufficientlyReplicatedAfterPending?
Contributor
Author
There was a problem hiding this comment.
I see I have a typo in there - is that what you are referring to? sufficient -> sufficiently ?
Contributor
|
@sodonnel overall patch looks good to me. After changing the method name type, I am +1 on this. |
umamaheswararao
approved these changes
Jun 14, 2022
Contributor
umamaheswararao
left a comment
umamaheswararao
left a comment
There was a problem hiding this comment.
LGTM, pending CI
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Jun 23, 2022
* master: (34 commits) HDDS-6868 Add S3Auth information to thread local (apache#3527) HDDS-6877. Keep replication port unchanged when restarting datanode in MiniOzoneCluster (apache#3510) HDDS-6907. OFS should create buckets with FILE_SYSTEM_OPTIMIZED layout. (apache#3528) HDDS-6875. Migrate parameterized tests in hdds-common to JUnit5 (apache#3513) HDDS-6924. OBJECT_STORE isn't flat namespaced (apache#3533) HDDS-6899. [EC] Remove warnings and errors from console during online reconstruction of data. (apache#3522) HDDS-6695. Enable SCM Ratis by default for new clusters only (apache#3499) HDDS-4123. Integrate OM Open Key Cleanup Service Into Existing Code (apache#3319) HDDS-6882. Correct exit code for invalid arguments passed to command-line tools. (apache#3517) HDDS-6890. EC: Fix potential wrong replica read with over-replicated container. (apache#3523) HDDS-6902. Duplicate mockito-core entries in pom.xml (apache#3525) HDDS-6752. Migrate tests with rules in hdds-server-scm to JUnit5 (apache#3442) HDDS-6806. EC: Implement the EC Reconstruction coordinator. (apache#3504) HDDS-6829. Limit the no of inflight replication tasks in SCM. (apache#3482) HDDS-6898. [SCM HA finalization] Modify acceptance test configuration to speed up test finalization (apache#3521) HDDS-6577. Configurations to reserve HDDS volume space. (apache#3484) HDDS-6870 Clean up isTenantAdmin to use UGI (apache#3503) HDDS-6872. TestAuthorizationV4QueryParser should pass offline (apache#3506) HDDS-6840. Add MetaData volume information to the SCM and OM - UI (apache#3488) HDDS-6697. EC: ReplicationManager - create class to detect EC container health issues (apache#3512) ...
guihecheng
pushed a commit
to guihecheng/ozone
that referenced
this pull request
Jun 28, 2022
… container health issues (apache#3512)" This reverts commit be29c67.
duongkame
pushed a commit
to duongkame/ozone
that referenced
this pull request
Aug 16, 2022
HDDS-6697. EC: ReplicationManager - create class to detect EC container health issues (apache#3512) (cherry picked from commit be29c67) Change-Id: I5f895f60d7ecba2a3b37dfd92c42fce7fb2c9611
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR defines a ContainerHealthCheckInterface, with the following definition:
And also an implementation for EC containers that can determine if an EC container is over or under replicated. The interface will return a ContainerHealthResult object that contains information about the health state. Eg for under replicated, it will contain details about the remaining redundancy, whether its due to decommission etc.
For now this class is standalone and unused. It will be integrated with ReplicationManager soon via a new Jira.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6697
How was this patch tested?
New unit tests