Skip to content

HDDS-5481. Fix stream() and link() method in ContainerStateMachine #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
captainzmc merged 1 commit into from
Jul 22, 2021
Merged

HDDS-5481. Fix stream() and link() method in ContainerStateMachine #2451

captainzmc merged 1 commit into from
Jul 22, 2021

Conversation

@kaijchen
Copy link
Member

@kaijchen kaijchen commented Jul 22, 2021

What changes were proposed in this pull request?

  1. Fix an inconsistency in parsing the request in stream() method with the startTransaction() method. This inconsistency caused the stream close issue in our POC code. Refer to the JIRA for more details.
  2. Add @Override annotation to link() method.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-5481

How was this patch tested?

This patch is tested in our POC code, see this commit, so we dont need to do ugly workarounds like this commit.

Unit tests will be added later after the client is finished.

@kaijchen kaijchen changed the title [HDDS-5481] Fix stream() and link() method in ContainerStateMachine HDDS-5481. Fix stream() and link() method in ContainerStateMachine Jul 22, 2021
ferhui
ferhui approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@ferhui ferhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

captainzmc
captainzmc approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@captainzmc captainzmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 Thanks for @ckj996 ’s patch. This help us fixe the issue of client stream could not close.

@captainzmc captainzmc merged commit 8cd6873 into apache:HDDS-4454 Jul 22, 2021
captainzmc pushed a commit to captainzmc/hadoop-ozone that referenced this pull request Jul 26, 2021
@kaijchen @captainzmc
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (a…
b3a38bf 
…pache#2451)
captainzmc pushed a commit to captainzmc/hadoop-ozone that referenced this pull request Jul 26, 2021
@kaijchen @captainzmc
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (a…
84a72e7 
…pache#2451)
@kaijchen kaijchen mentioned this pull request Jul 26, 2021
Merged
captainzmc pushed a commit to captainzmc/hadoop-ozone that referenced this pull request Jul 27, 2021
@kaijchen @captainzmc
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (a…
a1dc0a0 
…pache#2451)
szetszwo pushed a commit that referenced this pull request Jul 28, 2021
@kaijchen @szetszwo
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (#…
3c7dba2 
…2451)
szetszwo pushed a commit that referenced this pull request Aug 26, 2021
@kaijchen @szetszwo
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (#…
2972386 
…2451)
szetszwo pushed a commit that referenced this pull request Sep 8, 2021
@kaijchen @szetszwo
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (#…
1924810 
…2451)
szetszwo pushed a commit that referenced this pull request Oct 1, 2021
@kaijchen @szetszwo
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (#…
2cd909d 
…2451)
szetszwo pushed a commit that referenced this pull request Oct 19, 2021
@kaijchen @szetszwo
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (#…
b98d551 
…2451)
szetszwo pushed a commit that referenced this pull request Oct 28, 2021
@kaijchen @szetszwo
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (#…
6211d74 
…2451)
szetszwo pushed a commit that referenced this pull request Nov 15, 2021
@kaijchen @szetszwo
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (#…
0cc389a 
…2451)
szetszwo pushed a commit that referenced this pull request Nov 30, 2021
@kaijchen @szetszwo
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (#…
8e8af7f 
…2451)
captainzmc pushed a commit that referenced this pull request Dec 20, 2021
@kaijchen @captainzmc
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (#…
cf6b269 
…2451)
szetszwo pushed a commit that referenced this pull request Dec 30, 2021
@kaijchen @szetszwo
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (#…
433979d 
…2451)
szetszwo pushed a commit that referenced this pull request Jan 20, 2022
@kaijchen @szetszwo
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (#…
14350a5 
…2451)
captainzmc pushed a commit that referenced this pull request Feb 9, 2022
@kaijchen @captainzmc
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (#…
44ea00b 
…2451)
szetszwo pushed a commit that referenced this pull request Feb 16, 2022
@kaijchen @szetszwo
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (#…
95838f5 
…2451)
@kaijchen kaijchen deleted the patch-HDDS-5481 branch February 25, 2022 02:49
szetszwo pushed a commit that referenced this pull request Mar 15, 2022
@kaijchen @szetszwo
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (#…
82af9d7 
…2451)
szetszwo pushed a commit that referenced this pull request Mar 24, 2022
@kaijchen @szetszwo
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (#…
8efe195 
…2451)
szetszwo pushed a commit to szetszwo/ozone that referenced this pull request May 6, 2022
@kaijchen @szetszwo
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (a…
d32ae35 
…pache#2451)
szetszwo pushed a commit that referenced this pull request May 13, 2022
@kaijchen @szetszwo
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (#…
c6a242e 
…2451)
szetszwo pushed a commit that referenced this pull request May 24, 2022
@kaijchen @szetszwo
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (#…
6f9ef07 
…2451)
szetszwo pushed a commit that referenced this pull request Jun 9, 2022
@kaijchen @szetszwo
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (#…
0eee890 
…2451)
captainzmc pushed a commit to captainzmc/hadoop-ozone that referenced this pull request Jul 4, 2022
@kaijchen @captainzmc
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (a…
bda7004 
…pache#2451)
szetszwo pushed a commit that referenced this pull request Oct 25, 2022
@kaijchen @szetszwo
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (#…
01beaf8 
…2451)

(cherry picked from commit bda7004)
(cherry picked from commit 444b7b38406fbcc4c6ec957a10273ff1ee58cdfb)
szetszwo pushed a commit that referenced this pull request Nov 7, 2022
@kaijchen @szetszwo
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (#…
28d3035 
…2451)

(cherry picked from commit bda7004)
(cherry picked from commit 444b7b38406fbcc4c6ec957a10273ff1ee58cdfb)
(cherry picked from commit 01beaf8)
szetszwo pushed a commit that referenced this pull request Dec 1, 2022
@kaijchen @szetszwo
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (#…
f06e763 
…2451)

(cherry picked from commit 28d3035)
szetszwo pushed a commit that referenced this pull request Dec 16, 2022
@kaijchen @szetszwo
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (#…
9eafca6 
…2451)

(cherry picked from commit 28d3035)
nishitpatira pushed a commit to nishitpatira/ozone that referenced this pull request Dec 16, 2022
@kaijchen
HDDS-5481. Fix stream() and link() method in ContainerStateMachine. (a…
c896610 
…pache#2451)

(cherry picked from commit 28d3035)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ferhui ferhui ferhui approved these changes

@captainzmc captainzmc captainzmc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kaijchen @ferhui @captainzmc