Skip to content

Conversation

@kaijchen
Copy link
Member

What changes were proposed in this pull request?

Add link method to ContainerStateMachine for Ratis streaming.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-5452

How was this patch tested?

CI test will be added after the client is ready.

@captainzmc captainzmc requested a review from szetszwo July 16, 2021 09:39
Copy link
Contributor

@szetszwo szetszwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

Ozone datanode may store the log index somewhere using the link(..) method. This can be done later if there is a need.

@szetszwo
Copy link
Contributor

@ckj996 , there is a windbags warning. Please take a look. Thanks.

@kaijchen
Copy link
Member Author

@szetszwo Hi, I have fixed it. Can you please approve the workflow? Thanks.

@szetszwo szetszwo merged commit af10e0e into apache:HDDS-4454 Jul 18, 2021
szetszwo added a commit that referenced this pull request Jul 18, 2021
szetszwo added a commit that referenced this pull request Jul 18, 2021
@szetszwo
Copy link
Contributor

Re-commit this for fixing the commit message format.

commit 97cb05c2eafc4a33001e739737a2064dd623f6a9 (HEAD -> HDDS-4454, origin/HDDS-4454)
Author: Kaijie Chen <[email protected]>
Date:   Sun Jul 18 12:18:10 2021 +0800

    HDDS-5452. Add link method to ContainerStateMachine for Ratis streaming (#2422)

@ckj996 , please use the standard commit message next time. Thanks.

@kaijchen
Copy link
Member Author

@ckj996 , please use the standard commit message next time. Thanks.

Sure.

Btw, I forgot to add the @Override annotation, shall we fix that?

captainzmc pushed a commit that referenced this pull request Jul 22, 2021
captainzmc pushed a commit to captainzmc/hadoop-ozone that referenced this pull request Jul 26, 2021
captainzmc pushed a commit to captainzmc/hadoop-ozone that referenced this pull request Jul 26, 2021
captainzmc pushed a commit to captainzmc/hadoop-ozone that referenced this pull request Jul 26, 2021
captainzmc pushed a commit to captainzmc/hadoop-ozone that referenced this pull request Jul 26, 2021
captainzmc pushed a commit to captainzmc/hadoop-ozone that referenced this pull request Jul 26, 2021
captainzmc pushed a commit to captainzmc/hadoop-ozone that referenced this pull request Jul 26, 2021
@szetszwo
Copy link
Contributor

Btw, I forgot to add the @Override annotation, shall we fix that?

Sure, let's add the @OverRide annotation when we change the file next time.

@kaijchen
Copy link
Member Author

Btw, I forgot to add the @Override annotation, shall we fix that?

Sure, let's add the @OverRide annotation when we change the file next time.

I've fixed it in HDDS-5481(#2451).

captainzmc pushed a commit to captainzmc/hadoop-ozone that referenced this pull request Jul 27, 2021
captainzmc pushed a commit to captainzmc/hadoop-ozone that referenced this pull request Jul 27, 2021
captainzmc pushed a commit to captainzmc/hadoop-ozone that referenced this pull request Jul 27, 2021
szetszwo added a commit that referenced this pull request Jul 28, 2021
szetszwo pushed a commit to szetszwo/ozone that referenced this pull request May 6, 2022
captainzmc pushed a commit to captainzmc/hadoop-ozone that referenced this pull request Jul 4, 2022
szetszwo pushed a commit that referenced this pull request Oct 25, 2022
…ng (#2422)

(cherry picked from commit b6e2143)
(cherry picked from commit 425bc95539a8de334125f4bfe38aff93f1730f5d)
szetszwo pushed a commit that referenced this pull request Nov 7, 2022
…ng (#2422)

(cherry picked from commit b6e2143)
(cherry picked from commit 425bc95539a8de334125f4bfe38aff93f1730f5d)
(cherry picked from commit 5626566)
szetszwo pushed a commit that referenced this pull request Dec 1, 2022
szetszwo pushed a commit that referenced this pull request Dec 16, 2022
nishitpatira pushed a commit to nishitpatira/ozone that referenced this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants