HDDS-5145. Extend Pipline/ReplicationConfig refactor with ECReplicationConfig #2206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodonnel
approved these changes
May 4, 2021
Contributor
sodonnel
left a comment
sodonnel
left a comment
There was a problem hiding this comment.
Changes LGTM. Thanks for fixing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-5047 / #2096 started to use
ReplicationConfiginPipelineand pipeline related SCM service on master.ReplicationConfigwas introduced in HDDS-5011, but it has two versions one for master #(2089) and one for the EC branch.(#2068)Merging master after HDDS-5047 requires small modification in the code to make HDDS-5047 compatible the ec version of HDDS-5011:
During the proto serialization / deserialization we should use optional ECReplicationConfig (if exists).
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5145
How was this patch tested?
With CI, The EC branch has compilation failure without this patch.