HDDS-5011. Introduce ECReplicationConfig and Java based ReplicationConfig implementation #2068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 22, 2021
sodonnel
reviewed
Mar 30, 2021
Contributor
|
This change looks fine to me. I just had a couple of questions inline above. |
sodonnel
approved these changes
Mar 31, 2021
| public int hashCode() { | ||
| return Objects.hash(replicationFactor); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Do we need a toProto() method for this one like the ECReplicationConfig, or is it serialized elsewhere? We can easily add it later if we need it anyway.
Member
Author
There was a problem hiding this comment.
RatisReplictionConfig is not serialized anymore to any ***ReplicationConfig proto structure. Only the replication factor is required which can be retrieved with either casting or using the getLegacyFactor helper method.
Member
Author
|
Planning to merge it tomorrow as there are no more concerns. @umamaheswararao let me know if you have any comments. |
Member
Author
|
Merging it now. Thanks the review @sodonnel and @umamaheswararao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SCM proto file should be extended to use ECReplicationConfig which can be de-/serialized to a specific ReplicationConfiguration.
Note: this is the bare minimum version of HDDS-4882 #1973 which doesn't include the refactor of the existing proto/persistent fields but de-/serialize them to the new java pojos.
This PR is marked as draft as it depends on #2064 (this PR includes that patch, too)
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5011
How was this patch tested?
With new unit tests and also with end2end testing based on branch https://github.com/elek/ozone/tree/ec where this (and #2064) are two patches from the commit list.