HDDS-5144. Create github check to alert when dependency tree is changed #2199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 28b2bbf.
This reverts commit bc8de05.
This reverts commit 3003848.
Co-authored-by: Doroszlai, Attila <[email protected]>
Co-authored-by: Doroszlai, Attila <[email protected]>
Co-authored-by: Doroszlai, Attila <[email protected]>
adoroszlai
approved these changes
May 3, 2021
| #sed expression removes the version. Usually license is not changed with version bumps | ||
| #jacoco and test dependencies are excluded | ||
| find . -type f -name "*.jar" | cut -c3- | perl -wpl -e 's/-[0-9]+(.[0-9]+)*(-SNAPSHOT)?+//g' | grep -v jacoco | grep -v hadoop-hdds-test-utils | sort > "$SCRIPTDIR"/$REPORT_NAME | ||
| find . -type f -name "*.jar" | cut -c3- | perl -wpl -e 's/-[0-9]+(.[0-9]+)*(-SNAPSHOT)?+//g' | perl -wpl -e 's/[0-9a-z]+-SNAPSHOT//g' | grep -v jacoco | grep -v hadoop-hdds-test-utils | sort > "$SCRIPTDIR"/$REPORT_NAME |
Contributor
There was a problem hiding this comment.
Nit: the hash in snapshot jars could be handled by replacing (-SNAPSHOT)? with (-([0-9a-f]+-)?SNAPSHOT)?. One less perl command, no ugly - suffix in jar names.
Member
Author
There was a problem hiding this comment.
Good idea, thanks for the suggestion. Pushed the fix in b9b7dae, will merge it once we have a green build.
Contributor
|
Thanks @elek for updating the patch. Merging it after a green build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fixed version (handles ratis snapshots) of #2177
JIRA: https://issues.apache.org/jira/browse/HDDS-5144
What changes were proposed in this pull request?
hadoop-ozone/dist/src/main/license/bin/LICENSE.txtandhadoop-ozone/dist/src/main/license/bin/LICENSE.txtshould be modified when the transitive dependencies are changed.However, it's very easy to miss any dependency change when we bump versions. It's possible that we change only versions but we also introduce new jar files via transitive dependencies.
This happened (for example) in #2139 and #2065
To avoid any mistake I suggest the same approach what we use the protobuf compatibility check:
If new dependency is introduced, the LICENSE file can be updated and the committed jar list also can be updated.
How was this patch tested?
Tested on my fork.
Example of failing builds:
https://github.com/elek/ozone/runs/2407951331?check_suite_focus=true