Skip to content

Conversation

@adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented Apr 29, 2021

What changes were proposed in this pull request?

Newly introduced dependency check is failing on master because Ratis SNAPSHOT jars have SHA, but it is missing in the baseline list of jars. Since version numbers in general are intended to be ignored for the dependency check, we need to remove the SHA, too.

Changed jars:

--- /dev/fd/63	2021-04-29 09:44:00.396023295 +0000
+++ /dev/fd/62	2021-04-29 09:44:00.396023295 +0000
@@ -203,16 +203,16 @@
 share/ozone/lib/protobuf-java-util.jar
 share/ozone/lib/protobuf-java.jar
 share/ozone/lib/protobuf-java.jar
-share/ozone/lib/ratis-client.jar
-share/ozone/lib/ratis-common.jar
-share/ozone/lib/ratis-grpc.jar
-share/ozone/lib/ratis-metrics.jar
-share/ozone/lib/ratis-netty.jar
-share/ozone/lib/ratis-proto.jar
-share/ozone/lib/ratis-server-api.jar
-share/ozone/lib/ratis-server.jar
+share/ozone/lib/ratis-client-ff8aa66-SNAPSHOT.jar
+share/ozone/lib/ratis-common-ff8aa66-SNAPSHOT.jar
+share/ozone/lib/ratis-grpc-ff8aa66-SNAPSHOT.jar
+share/ozone/lib/ratis-metrics-ff8aa66-SNAPSHOT.jar
+share/ozone/lib/ratis-netty-ff8aa66-SNAPSHOT.jar
+share/ozone/lib/ratis-proto-ff8aa66-SNAPSHOT.jar
+share/ozone/lib/ratis-server-api-ff8aa66-SNAPSHOT.jar
+share/ozone/lib/ratis-server-ff8aa66-SNAPSHOT.jar
 share/ozone/lib/ratis-thirdparty-misc-a398b19-SNAPSHOT.jar
-share/ozone/lib/ratis-tools.jar
+share/ozone/lib/ratis-tools-ff8aa66-SNAPSHOT.jar
 share/ozone/lib/re2j.jar
 share/ozone/lib/rocksdbjni.jar
 share/ozone/lib/simpleclient.jar

https://issues.apache.org/jira/browse/HDDS-5144

How was this patch tested?

mvn -DskipTests clean verify
hadoop-ozone/dev-support/checks/dependency.sh

@adoroszlai adoroszlai self-assigned this Apr 29, 2021
@adoroszlai adoroszlai requested a review from elek April 29, 2021 12:43
@adoroszlai
Copy link
Contributor Author

Closing as #2177 was reverted.

@adoroszlai adoroszlai closed this Apr 29, 2021
@elek
Copy link
Member

elek commented May 3, 2021

Ups, sorry, I didn't notice this one until now. Seems to be the same as #2199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants