HDDS-5118. Recover from failure during upgrade action. #2179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* HDDS-3698-nonrolling-upgrade: HDDS-5108. Attempt to remove state from *UpgradeFinalizer classes. (apache#2160) Update upgrade-dev-primer.md
avijayanhwx
approved these changes
Apr 28, 2021
Contributor
avijayanhwx
left a comment
avijayanhwx
left a comment
There was a problem hiding this comment.
Thanks for working on this @errose28. LGTM +1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove the
upgradingToLayoutVersionVERSION file marker, which was previously used to mark a finalization action as in progress in case of a crash during the action. There will be no special handling for this case, and documentation is updated to indicate that finalization actions that fail will be re-run on a subsequent finalize call. The pre-finalize validation action can be used for necessary cleanup on startup. Docs for other upgrade actions have also been updated, although their behavior is not modified.What is the link to the Apache JIRA
HDDS-5118
How was this patch tested?
Unit tests updated.