Skip to content

HDDS-5108. Attempt to remove state from *UpgradeFinalizer classes. #2160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
avijayanhwx merged 9 commits into from
Apr 22, 2021
Merged

HDDS-5108. Attempt to remove state from *UpgradeFinalizer classes. #2160

avijayanhwx merged 9 commits into from
Apr 22, 2021

Conversation

@avijayanhwx
Copy link
Contributor

@avijayanhwx avijayanhwx commented Apr 19, 2021

What changes were proposed in this pull request?

  • Refactor upgrade finalizer classes.
  • Allow prepare command to succeed even if majority of OMs are prepared.
  • Other minor fixes

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-5108

How was this patch tested?

Manually tested.
Added unit tests.

@avijayanhwx
Copy link
Contributor Author

avijayanhwx commented Apr 20, 2021

cc @errose28 for review.

@fapifta
Copy link
Contributor

fapifta commented Apr 20, 2021

Hi @avijayanhwx,

thank you for taking on this, I think it is a great improvement in the code and I like the approach. I did a quick scroll though only so far, would like to take a deeper look, but if I don't get back to you in time, and others do not see anything that should be addressed, feel free to push it and don't wait for me, as I can not promise to get to it in reasonable time.

errose28
errose28 reviewed Apr 21, 2021
View reviewed changes
Copy link
Contributor

@errose28 errose28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @avijayanhwx, I like that more upgrade code has been moved out of each component class, and the reduced code duplication for finalizing each component. Just a few inline comments/questions.

@avijayanhwx
Copy link
Contributor Author

avijayanhwx commented Apr 21, 2021

Thank you for the review @errose28. I have addressed your comments.

@errose28
Copy link
Contributor

errose28 commented Apr 21, 2021

Thanks for the updates. LGTM +1.

fapifta
fapifta reviewed Apr 22, 2021
View reviewed changes
Copy link
Contributor

@fapifta fapifta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @avijayanhwx,

thank you for your patience, I went through the changes, and found a few minor things, I am sharing inline.

Looking at the bigger picture, the refactoring seems to be successful.

One thing I would like to note, I am not sure if you have any plans with UpgradeActions, and UpgradeActionType, and how it is defined and used, but that might be an other are for improvements with a similar approach, but this is certainly out of scope here to do.

@avijayanhwx
Copy link
Contributor Author

avijayanhwx commented Apr 22, 2021

Thanks for the review @fapifta. I have addressed your comments.

@fapifta
Copy link
Contributor

fapifta commented Apr 22, 2021

Hi @avijayanhwx,

thank you for addressing all the things, I think the changes are good.
I just saw one last missing NL at the end of DefaultUpgradeFinalizationExecutor, if you would like to fix it, with or without that, I think we are good to go.

fapifta
fapifta approved these changes Apr 22, 2021 •
edited
Loading
View reviewed changes
@avijayanhwx
Copy link
Contributor Author

avijayanhwx commented Apr 22, 2021

Merging without CI since last commit just added newline.

Thanks for keeping me honest @errose28 & @fapifta!

@avijayanhwx avijayanhwx merged commit 2823320 into apache:HDDS-3698-nonrolling-upgrade Apr 22, 2021
errose28 added a commit to errose28/ozone that referenced this pull request Apr 22, 2021
@errose28
Merge branch 'HDDS-3698-nonrolling-upgrade' into HDDS-5118
7801986 
* HDDS-3698-nonrolling-upgrade:
  HDDS-5108. Attempt to remove state from *UpgradeFinalizer classes. (apache#2160)
  Update upgrade-dev-primer.md
@errose28 errose28 mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@errose28 errose28 errose28 left review comments

@fapifta fapifta fapifta approved these changes

@prashantpogde prashantpogde Awaiting requested review from prashantpogde

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@avijayanhwx @fapifta @errose28