Skip to content

HDDS-5066. Use fixed version from pnpm to build recon #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
prashantpogde merged 1 commit into from
Apr 6, 2021
Merged

HDDS-5066. Use fixed version from pnpm to build recon #2115

prashantpogde merged 1 commit into from
Apr 6, 2021

Conversation

@elek
Copy link
Member

@elek elek commented Apr 6, 2021 •
edited
Loading

What changes were proposed in this pull request?

Recon build is broken since yesterday due to a new [email protected] release

[INFO] Running 'npx pnpm config set store-dir ~/.pnpm-store' in /home/elek/projects/ozone/hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web
[INFO] npx: installed 1 in 1.057s
[INFO] ERROR: This version of pnpm requires at least Node.js v12.17
[INFO] The current version of Node.js is v12.14.1
[INFO] Visit https://r.pnpm.io/comp to see the list of past pnpm versions with respective Node.js version support.

This is because the frontend maven plugin uses npx which downloads the required tools (pnpm in our case) on-demand if they are not available locally.

This download uses the latest version (by default).

I recommend using a fixed version from pnpm to avoid any unexpected error when external tools is updated.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-5066

How was this patch tested?

The problem was reproducible with simple build. Tested with local build.

@elek elek requested a review from vivekratnavel April 6, 2021 12:13
@adoroszlai adoroszlai changed the title HDDS-5066. Use fixed vesion from pnpm to build recon HDDS-5066. Use fixed version from pnpm to build recon Apr 6, 2021
adoroszlai
adoroszlai reviewed Apr 6, 2021
View reviewed changes
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elek for fixing this.

@elek
Copy link
Member Author

elek commented Apr 6, 2021

/cc @prashantpogde I think it's also required for 1.1 to have stable build...

@apache apache deleted a comment from github-actions bot Apr 6, 2021
@prashantpogde
Copy link
Contributor

prashantpogde commented Apr 6, 2021

+1

@prashantpogde
Copy link
Contributor

prashantpogde commented Apr 6, 2021

Merging it as we need to cherrypick this change for 1.1.0.

@prashantpogde prashantpogde merged commit d1d4303 into apache:master Apr 6, 2021
@vivekratnavel
Copy link
Contributor

vivekratnavel commented Apr 6, 2021

Thanks, @elek for fixing this and @adoroszlai @prashantpogde for reviewing and merging.

errose28 added a commit to errose28/ozone that referenced this pull request Apr 6, 2021
@errose28
Merge branch 'master' into HDDS-3698-nonrolling-upgrade
72de752 
* master:
  HDDS-5066. Use fixed vesion from pnpm to build recon (apache#2115)
  HDDS-5035. Use default config values to solve generated config file conflict (apache#2087)
  HDDS-5032. DN stopped to load containers on volume after a container load exception. (apache#2109)
  HDDS-4504. Datanode deletion config should be based on number of blocks (apache#1885)
prashantpogde pushed a commit to prashantpogde/hadoop-ozone that referenced this pull request Apr 6, 2021
@elek
HDDS-5066. Use fixed vesion from pnpm to build recon (apache#2115)
ea403b3 
(cherry picked from commit d1d4303)
prashantpogde pushed a commit that referenced this pull request Apr 6, 2021
@elek
HDDS-5066. Use fixed vesion from pnpm to build recon (#2115)
042a4fc 
(cherry picked from commit d1d4303)
@ChenSammi
Copy link
Contributor

ChenSammi commented Apr 7, 2021

Thanks @elek for fix it. I also met the issue locally yesterday.

errose28 added a commit to errose28/ozone that referenced this pull request Apr 7, 2021
@errose28
Merge branch 'HDDS-3698-nonrolling-upgrade' into HDDS-4181
a00ddb6 
* HDDS-3698-nonrolling-upgrade: (144 commits)
  fix project name in NOTICE.txt (apache#2112)
  HDDS-5066. Use fixed vesion from pnpm to build recon (apache#2115)
  HDDS-5014. Add non-rolling upgrade design docs.
  HDDS-5035. Use default config values to solve generated config file conflict (apache#2087)
  HDDS-5032. DN stopped to load containers on volume after a container load exception. (apache#2109)
  HDDS-4504. Datanode deletion config should be based on number of blocks (apache#1885)
  Fix ozone-ha acceptance test.
  HDDS-5058. Make getScmInfo retry for a duration.
  HDDS-4506. Support query parameter based v4 auth in S3g (apache#1628)
  HDDS-4553. ChunkInputStream should release buffer as soon as last byte in the buffer is read (apache#2062)
  HDDS-5022. SCM get roles command should provide Ratis Leader/Follower… (apache#2098)
  HDDS-5033. SCM may not be able to know full port list of Datanode after Datanode is started. (apache#2090)
  HDDS-3752. Fix o3fs list bucket contents issue when without tailing "/" (apache#2088)
  HDDS-4901. Remove OmOzoneAclMap from OmVolumeArgs to avoid OzoneAcl conversions (apache#1992)
  HDDS-4987. Import container should not delete container contents if container already exists (apache#2077)
  Checkstyle fix.
  Intialize DN layout version before security init.
  HDDS-4915. [SCM HA Security] Integrate CertClient. (apache#2000)
  HDDS-5049. Add timeout support for ratis requests in SCM HA. (apache#2099)
  trigger new CI check
  ...
errose28 added a commit to errose28/ozone that referenced this pull request Apr 7, 2021
@errose28
Merge branch 'HDDS-3698-nonrolling-upgrade' into HDDS-4828
b52033f 
* HDDS-3698-nonrolling-upgrade:
  fix project name in NOTICE.txt (apache#2112)
  HDDS-5066. Use fixed vesion from pnpm to build recon (apache#2115)
  HDDS-5014. Add non-rolling upgrade design docs.
  HDDS-5035. Use default config values to solve generated config file conflict (apache#2087)
  HDDS-5032. DN stopped to load containers on volume after a container load exception. (apache#2109)
  HDDS-4504. Datanode deletion config should be based on number of blocks (apache#1885)
errose28 added a commit to errose28/ozone that referenced this pull request Apr 9, 2021
@errose28
Merge branch 'HDDS-3698-nonrolling-upgrade' into HDDS-4992
fe0e244 
* HDDS-3698-nonrolling-upgrade: (150 commits)
  HDDS-5056. Avoid false positiver error messages during pipeline creations (apache#2105)
  HDDS-5027. [SCM HA Security] Handle leader changes during bootstrap. (apache#2113)
  HDDS-5032. Fix findbugs (apache#2120)
  HDDS-5062. Add a config to bypass clusterId validation for bootstrapping SCM. (apache#2114)
  HDDS-5011. Introduce Java based ReplicationConfig implementation (apache#2089)
  HDDS-4925. Introduce ContainerBalancer in SCM with start/stop capabilities. (apache#2097)
  fix project name in NOTICE.txt (apache#2112)
  HDDS-5066. Use fixed vesion from pnpm to build recon (apache#2115)
  HDDS-5014. Add non-rolling upgrade design docs.
  HDDS-5035. Use default config values to solve generated config file conflict (apache#2087)
  HDDS-5032. DN stopped to load containers on volume after a container load exception. (apache#2109)
  HDDS-4504. Datanode deletion config should be based on number of blocks (apache#1885)
  Fix ozone-ha acceptance test.
  HDDS-5058. Make getScmInfo retry for a duration.
  HDDS-4506. Support query parameter based v4 auth in S3g (apache#1628)
  HDDS-4553. ChunkInputStream should release buffer as soon as last byte in the buffer is read (apache#2062)
  HDDS-5022. SCM get roles command should provide Ratis Leader/Follower… (apache#2098)
  HDDS-5033. SCM may not be able to know full port list of Datanode after Datanode is started. (apache#2090)
  HDDS-3752. Fix o3fs list bucket contents issue when without tailing "/" (apache#2088)
  HDDS-4901. Remove OmOzoneAclMap from OmVolumeArgs to avoid OzoneAcl conversions (apache#1992)
  ...
prashantpogde pushed a commit to prashantpogde/hadoop-ozone that referenced this pull request Apr 14, 2021
@elek
HDDS-5066. Use fixed vesion from pnpm to build recon (apache#2115)
32c13b1 
(cherry picked from commit d1d4303)
jojochuang pushed a commit to jojochuang/ozone that referenced this pull request Jun 3, 2021
@elek @jojochuang
HDDS-5066. Use fixed vesion from pnpm to build recon (apache#2115)
ef0d6df 
(cherry picked from commit d1d4303)
@errose28 errose28 mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adoroszlai adoroszlai adoroszlai left review comments

@vivekratnavel vivekratnavel Awaiting requested review from vivekratnavel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@elek @prashantpogde @vivekratnavel @ChenSammi @adoroszlai