HDDS-5049. Add timeout support for ratis requests in SCM HA. #2099
Conversation
|
@GlenGeng , can you have a look? |
| = TimeDuration.valueOf(1, TimeUnit.SECONDS); | ||
|
|
||
| public static final String OZONE_SCM_RATIS_REQUEST_TIMEOUT_KEY | ||
| = "ozone.scm.ratis.minimum.timeout"; |
There was a problem hiding this comment.
Should we add the key to SCMHAConfiguration ?
BTW, the key OZONE_SCM_RATIS_SERVER_REQUEST_TIMEOUT_KEY, OZONE_SCM_RATIS_SERVER_RETRY_CACHE_TIMEOUT_KEY, OZONE_SCM_RATIS_MINIMUM_TIMEOUT_KEY, OZONE_SCM_LEADER_ELECTION_MINIMUM_TIMEOUT_DURATION_KEY etc are not used any more. Better clean up them.
There was a problem hiding this comment.
I think, we should be remove SCMHAConfiguration and pull all the required configs in ScmConfigKeys and remove the unused ones. But, i would prefer to do this as a part of different jira altogether.
https://issues.apache.org/jira/browse/HDDS-5054 is opened to track the same.
There was a problem hiding this comment.
Sure. Thanks for creating the jira.
|
+1. Thanks @bshashikant for the work. I will merge it. |
* HDDS-3698-nonrolling-upgrade: (144 commits) fix project name in NOTICE.txt (apache#2112) HDDS-5066. Use fixed vesion from pnpm to build recon (apache#2115) HDDS-5014. Add non-rolling upgrade design docs. HDDS-5035. Use default config values to solve generated config file conflict (apache#2087) HDDS-5032. DN stopped to load containers on volume after a container load exception. (apache#2109) HDDS-4504. Datanode deletion config should be based on number of blocks (apache#1885) Fix ozone-ha acceptance test. HDDS-5058. Make getScmInfo retry for a duration. HDDS-4506. Support query parameter based v4 auth in S3g (apache#1628) HDDS-4553. ChunkInputStream should release buffer as soon as last byte in the buffer is read (apache#2062) HDDS-5022. SCM get roles command should provide Ratis Leader/Follower… (apache#2098) HDDS-5033. SCM may not be able to know full port list of Datanode after Datanode is started. (apache#2090) HDDS-3752. Fix o3fs list bucket contents issue when without tailing "/" (apache#2088) HDDS-4901. Remove OmOzoneAclMap from OmVolumeArgs to avoid OzoneAcl conversions (apache#1992) HDDS-4987. Import container should not delete container contents if container already exists (apache#2077) Checkstyle fix. Intialize DN layout version before security init. HDDS-4915. [SCM HA Security] Integrate CertClient. (apache#2000) HDDS-5049. Add timeout support for ratis requests in SCM HA. (apache#2099) trigger new CI check ...
2 participants
What changes were proposed in this pull request?
Added Timeout support for ratis requests.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5049
How was this patch tested?
Existing UT