HDDS-1737. Add Volume check in KeyManager and File Operations. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 369e206a3b6505013fa8b4933cd89bc6a8a4c27c.
Add some tests for the fixing of request.
Member
Author
|
/retest |
jojochuang
reviewed
Oct 15, 2019
| omDirectoryCreateRequest.validateAndUpdateCache(ozoneManager, 100L, | ||
| ozoneManagerDoubleBufferHelper); | ||
|
|
||
| Assert.assertTrue(omClientResponse.getOMResponse().getStatus() |
Contributor
There was a problem hiding this comment.
use Assert.assertEquals() instead
| == OzoneManagerProtocolProtos.Status.VOLUME_NOT_FOUND); | ||
|
|
||
| // Key should not exist in DB | ||
| Assert.assertTrue(omMetadataManager.getKeyTable().get( |
Member
Author
There was a problem hiding this comment.
Thanks @jojochuang for the review, I am going to fix it.
elek
approved these changes
Oct 16, 2019
Member
elek
left a comment
elek
left a comment
There was a problem hiding this comment.
+1
Looks good to me. Also checked the unit tests locally.
Thanks the patch @cxorm (and the migration) and the review @jojochuang and @bharatviswa504 (on the old PR)
Member
Author
|
Thanks @bharatviswa504 and @jojochuang for the review. |
tanvipenumudy
added a commit
to tanvipenumudy/ozone
that referenced
this pull request
May 12, 2022
# This is the 1st commit message: Initial Commit # This is the commit message apache#2: more slight changes # This is the commit message apache#3: changes++ # This is the commit message apache#4: getExecutorService Changes # This is the commit message apache#5: applyTransaction() Changes # This is the commit message apache#6: changes++ # This is the commit message apache#7: TestOzoneManagerLock changes # This is the commit message apache#8: add changes # This is the commit message apache#9: add more minor changes # This is the commit message apache#10: add config to ozone-default.xml # This is the commit message apache#11: minor changes # This is the commit message apache#12: change modulo logic # This is the commit message apache#13: changes # This is the commit message apache#14: changes++ # This is the commit message apache#15: add changes++ # This is the commit message apache#16: minor changes # This is the commit message apache#17: Changes (to be reverted) # This is the commit message apache#18: Changes 09/05
2 tasks
tanvipenumudy
added a commit
to tanvipenumudy/ozone
that referenced
this pull request
May 18, 2023
# This is the 1st commit message: test om command changes 2 # This is the commit message apache#2: Add entry in OzoneManagerRequestHandler
apotheque
referenced
this pull request
in apotheque/ozone
Mar 12, 2025
apotheque
referenced
this pull request
in apotheque/ozone
Mar 15, 2025
vtutrinov
referenced
this pull request
in vtutrinov/ozone
Apr 7, 2025
fmorg-git
pushed a commit
to fmorg-git/ozone
that referenced
this pull request
Oct 3, 2025
HDDS-13724. More classes to store temporary secrets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute