Skip to content

Conversation

@elek
Copy link
Member

@elek elek commented Oct 14, 2019

What changes were proposed in this pull request?

HDDS-2022 introduced new freon tests, but the initial root span of opentracing is not created before the test execution. We need to enable opentracing to get better view about the executions of the new freon test.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-2297

How this patch can be tested?

Start an ozoneperf cluster:

cd hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/compose/ozoneperf/
docker-compose up -d --scale datanode=3

If HDDS-2296 is not yet merged, stop old-style freon:

docker-compose stop freon

Start new freon test:

docker-compose exec scm bash
ozone freon ockg -n 10

Open the jaeger web ui: http://localhost:16686/

Choose freon under the service and click to the search.

On the right side you should see results with the name freon: OzoneClientKeyGenerator and with multiple sub-spans.

Without the patch you can see entries with strange name (...span without root...)

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well.

Copy link
Contributor

@bharatviswa504 bharatviswa504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.
Tested with given steps, able to see the trace.

@bharatviswa504 bharatviswa504 merged commit e16275d into apache:master Oct 24, 2019
@bharatviswa504
Copy link
Contributor

Thank You @elek for the contribution and @adoroszlai for the review.

maobaolong added a commit to maobaolong/hadoop-ozone that referenced this pull request Aug 24, 2020
tanvipenumudy added a commit to tanvipenumudy/ozone that referenced this pull request May 12, 2022
# This is the 1st commit message:

Initial Commit

# This is the commit message apache#2:

more slight changes

# This is the commit message apache#3:

changes++

# This is the commit message apache#4:

getExecutorService Changes

# This is the commit message apache#5:

applyTransaction() Changes

# This is the commit message apache#6:

changes++

# This is the commit message apache#7:

TestOzoneManagerLock changes

# This is the commit message apache#8:

add changes

# This is the commit message apache#9:

add more minor changes

# This is the commit message apache#10:

add config to ozone-default.xml

# This is the commit message apache#11:

minor changes

# This is the commit message apache#12:

change modulo logic

# This is the commit message apache#13:

changes

# This is the commit message apache#14:

changes++

# This is the commit message apache#15:

add changes++

# This is the commit message apache#16:

minor changes

# This is the commit message apache#17:

Changes (to be reverted)

# This is the commit message apache#18:

Changes 09/05
ptlrs pushed a commit to ptlrs/ozone that referenced this pull request Mar 8, 2025
… throws error (apache#16)

* CDPD-70409: Recon Overview Page UI fails to load if Recon Solr Health throws error

* CDPD-70409: Recon Overview Page UI fails to load if Recon Solr Health throws error Flag Set Globally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants